You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@systemds.apache.org by ar...@apache.org on 2020/10/27 10:28:02 UTC
[systemds] branch master updated: [MINOR] Lineage tests cleanup
This is an automated email from the ASF dual-hosted git repository.
arnabp20 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/systemds.git
The following commit(s) were added to refs/heads/master by this push:
new ad590dd [MINOR] Lineage tests cleanup
ad590dd is described below
commit ad590ddebfa3328a4260c5320f957115cc203211
Author: arnabp <ar...@tugraz.at>
AuthorDate: Tue Oct 27 11:07:23 2020 +0100
[MINOR] Lineage tests cleanup
This patch removes unnecessary prints of lineage traces.
This also removes transformencode from reusable instruction list
as we don't support caching of frames yet.
---
.../java/org/apache/sysds/runtime/lineage/LineageCacheConfig.java | 2 +-
src/test/scripts/functions/lineage/LineageTraceBuiltin.dml | 6 ++++--
src/test/scripts/functions/lineage/LineageTraceFun1.dml | 2 +-
src/test/scripts/functions/lineage/LineageTraceFun2.dml | 2 +-
src/test/scripts/functions/lineage/LineageTraceParfor1.dml | 2 +-
src/test/scripts/functions/lineage/LineageTraceParfor2.dml | 2 +-
src/test/scripts/functions/lineage/LineageTraceParfor3.dml | 2 +-
src/test/scripts/functions/lineage/LineageTraceSpark5.dml | 2 +-
8 files changed, 11 insertions(+), 9 deletions(-)
diff --git a/src/main/java/org/apache/sysds/runtime/lineage/LineageCacheConfig.java b/src/main/java/org/apache/sysds/runtime/lineage/LineageCacheConfig.java
index c5d8298..b873205 100644
--- a/src/main/java/org/apache/sysds/runtime/lineage/LineageCacheConfig.java
+++ b/src/main/java/org/apache/sysds/runtime/lineage/LineageCacheConfig.java
@@ -40,7 +40,7 @@ public class LineageCacheConfig
"uamean", "max", "min", "ifelse", "-", "sqrt", ">", "uak+", "<=",
"^", "uamax", "uark+", "uacmean", "eigen", "ctableexpand", "replace",
"^2", "uack+", "tak+*", "uacsqk+", "uark+", "n+", "uarimax", "qsort",
- "qpick", "transformencode", "transformapply"
+ "qpick", "transformapply"
//TODO: Reuse everything.
};
private static String[] REUSE_OPCODES = new String[] {};
diff --git a/src/test/scripts/functions/lineage/LineageTraceBuiltin.dml b/src/test/scripts/functions/lineage/LineageTraceBuiltin.dml
index 598b9cc..49fe875 100644
--- a/src/test/scripts/functions/lineage/LineageTraceBuiltin.dml
+++ b/src/test/scripts/functions/lineage/LineageTraceBuiltin.dml
@@ -24,9 +24,11 @@ X = rand(rows=$3, cols=$4, seed=7);
R = X;
for(i in 1:7) {
R = R + 1 / 2;
- print(lineage(R));
+ #print(lineage(R));
+ linR = lineage(R);
}
R = R + X;
-print(lineage(R));
+#print(lineage(R));
+linR = lineage(R);
write(R, $2);
diff --git a/src/test/scripts/functions/lineage/LineageTraceFun1.dml b/src/test/scripts/functions/lineage/LineageTraceFun1.dml
index b7f4b39..34de649 100644
--- a/src/test/scripts/functions/lineage/LineageTraceFun1.dml
+++ b/src/test/scripts/functions/lineage/LineageTraceFun1.dml
@@ -37,5 +37,5 @@ Y = X^2;
[R, S] = foo(Y, X);
R = R - S;
-print(lineage(R));
+#print(lineage(R));
write(R, $2);
diff --git a/src/test/scripts/functions/lineage/LineageTraceFun2.dml b/src/test/scripts/functions/lineage/LineageTraceFun2.dml
index 52708e9..2e0bc45 100644
--- a/src/test/scripts/functions/lineage/LineageTraceFun2.dml
+++ b/src/test/scripts/functions/lineage/LineageTraceFun2.dml
@@ -36,5 +36,5 @@ Y = X^2;
[R, S] = foo(Y, X);
R = R - S;
-print(lineage(R));
+#print(lineage(R));
write(R, $2);
diff --git a/src/test/scripts/functions/lineage/LineageTraceParfor1.dml b/src/test/scripts/functions/lineage/LineageTraceParfor1.dml
index dc82d38..3cf0df9 100644
--- a/src/test/scripts/functions/lineage/LineageTraceParfor1.dml
+++ b/src/test/scripts/functions/lineage/LineageTraceParfor1.dml
@@ -28,5 +28,5 @@ parfor(i in 1:ncol(X)) {
R[,i] = rowSums(Xi)+colSums(Xi);
}
-print(lineage(R));
+#print(lineage(R));
write(R, $1);
diff --git a/src/test/scripts/functions/lineage/LineageTraceParfor2.dml b/src/test/scripts/functions/lineage/LineageTraceParfor2.dml
index a1fd11f..d209cd1 100644
--- a/src/test/scripts/functions/lineage/LineageTraceParfor2.dml
+++ b/src/test/scripts/functions/lineage/LineageTraceParfor2.dml
@@ -28,5 +28,5 @@ parfor(i in 1:ncol(X), check=0, opt=None, mode=REMOTE_SPARK) {
R[,i] = rowSums(Xi)+colSums(Xi);
}
-print(lineage(R));
+#print(lineage(R));
write(R, $1);
diff --git a/src/test/scripts/functions/lineage/LineageTraceParfor3.dml b/src/test/scripts/functions/lineage/LineageTraceParfor3.dml
index 7b8ad18..f379adf 100644
--- a/src/test/scripts/functions/lineage/LineageTraceParfor3.dml
+++ b/src/test/scripts/functions/lineage/LineageTraceParfor3.dml
@@ -27,5 +27,5 @@ parfor(i in 1:ncol(X), check=0, opt=None, mode=REMOTE_SPARK) {
R[1, i] = sum(Xi)
}
-print(lineage(R));
+#print(lineage(R));
write(R, $1);
diff --git a/src/test/scripts/functions/lineage/LineageTraceSpark5.dml b/src/test/scripts/functions/lineage/LineageTraceSpark5.dml
index 0625d68..9bb2dfe 100644
--- a/src/test/scripts/functions/lineage/LineageTraceSpark5.dml
+++ b/src/test/scripts/functions/lineage/LineageTraceSpark5.dml
@@ -33,6 +33,6 @@ for (v in 1:10, check=0) { # parallelizable
ms[,(v-1)*3+1:v*3] = mv
}
-print(lineage(ms));
+#print(lineage(ms));
write(ms, $2);
write(X, $3);