[GitHub] vdiravka commented on a change in pull request #1390: DRILL-6624: Fix loss of the table row type when the same schema name …

[GitBox <gi...@apache.org>]

vdiravka commented on a change in pull request #1390: DRILL-6624: Fix loss of the table row type when the same schema name …
URL: https://github.com/apache/drill/pull/1390#discussion_r204022404
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/calcite/jdbc/DynamicRootSchema.java
 ##########
 @@ -91,15 +91,17 @@ public void loadSchemaFactory(String schemaName, boolean caseSensitive) {
           return;
         }
 
-        // Found the storage plugin for first part(e.g. 'dfs') of schemaName (e.g. 'dfs.tmp')
-        // register schema for this storage plugin to 'this'.
-        plugin.registerSchemas(schemaConfig, thisPlus);
-
+        // Looking for the SchemaPlus for the top level (e.g. 'dfs') of schemaName (e.g. 'dfs.tmp')
+        SchemaPlus firstLevelSchema = thisPlus.getSubSchema(paths.get(0));
 
 Review comment:
   What is thisPlus? Could we consider renaming it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services