You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/03/15 06:05:08 UTC

[GitHub] [cordova-android] dpogue opened a new pull request #691: Run prepare with the correct ConfigParser version

dpogue opened a new pull request #691: Run prepare with the correct ConfigParser version
URL: https://github.com/apache/cordova-android/pull/691
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   android
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   See #690 : The ConfigParser passed in by cordova-lib is constructed from the cordova-common version that cordova-lib is using, rather than the one that cordova-ios is using.
   
   
   ### Description
   <!-- Describe your changes in detail -->
   Initialize the ConfigParser at the platform API level so that it uses the expected version.
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   All unit tests pass.
   
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [x] I added automated test coverage as appropriate for this change
   - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org