You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by ni...@apache.org on 2019/10/22 10:46:55 UTC

[servicecomb-pack] branch SCB-1541 created (now 60dc407)

This is an automated email from the ASF dual-hosted git repository.

ningjiang pushed a change to branch SCB-1541
in repository https://gitbox.apache.org/repos/asf/servicecomb-pack.git.


      at 60dc407  SCB-1541 Set the dependency of OpenFeign core scope to be provided

This branch includes the following new commits:

     new 60dc407  SCB-1541 Set the dependency of OpenFeign core scope to be provided

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.

[servicecomb-pack] 01/01: SCB-1541 Set the dependency of OpenFeign core scope to be provided

Posted by ni...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

ningjiang pushed a commit to branch SCB-1541
in repository https://gitbox.apache.org/repos/asf/servicecomb-pack.git

commit 60dc407c00f128a9da0b4e4564104211712c4d5d
Author: Willem Jiang <wi...@gmail.com>
AuthorDate: Tue Oct 22 18:42:28 2019 +0800

    SCB-1541 Set the dependency of OpenFeign core scope to be provided
---
 omega/omega-transport/omega-transport-feign/pom.xml | 4 +++-
 pom.xml                                             | 1 +
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/omega/omega-transport/omega-transport-feign/pom.xml b/omega/omega-transport/omega-transport-feign/pom.xml
index bf232ab..9d91cc3 100644
--- a/omega/omega-transport/omega-transport-feign/pom.xml
+++ b/omega/omega-transport/omega-transport-feign/pom.xml
@@ -32,7 +32,9 @@
         <dependency>
             <groupId>io.github.openfeign</groupId>
             <artifactId>feign-core</artifactId>
-            <version>9.5.1</version>
+            <version>${openfeign.version}</version>
+            <!-- here we don't specify the feign version, it should work with feign runtime -->
+            <scope>provided</scope>
         </dependency>
 
         <dependency>
diff --git a/pom.xml b/pom.xml
index 8690733..b79c2f3 100644
--- a/pom.xml
+++ b/pom.xml
@@ -77,6 +77,7 @@
     <zookeeper.version>3.4.13</zookeeper.version>
     <kafka.version>2.1.1</kafka.version>
     <hystrix.version>1.5.12</hystrix.version>
+    <openfeign.version>9.5.1</openfeign.version>
   </properties>
 
   <name>ServiceComb Saga</name>