[GitHub] [doris] platoneko commented on a diff in pull request #20889: [fix](compaction) fix time series compaction policy to adjust vertical compaction max segment size

["platoneko (via GitHub)" <gi...@apache.org>]

platoneko commented on code in PR #20889:
URL: https://github.com/apache/doris/pull/20889#discussion_r1233032250


##########
be/src/olap/cumulative_compaction_policy.h:
##########
@@ -33,7 +33,7 @@ namespace doris {
 class Tablet;
 struct Version;
 
-inline std::string_view CUMULATIVE_SIZE_BASED_POLICY = "SIZE_BASED";
+inline std::string_view CUMULATIVE_SIZE_BASED_POLICY = "size_based";

Review Comment:
   
   ```suggestion
   inline constexpr std::string_view CUMULATIVE_SIZE_BASED_POLICY = "size_based";
   ```



##########
be/src/olap/cumulative_compaction_time_series_policy.h:
##########
@@ -21,7 +21,7 @@
 
 namespace doris {
 
-inline std::string_view CUMULATIVE_TIME_SERIES_POLICY = "TIME_SERIES";
+inline std::string_view CUMULATIVE_TIME_SERIES_POLICY = "time_series";

Review Comment:
   
   ```suggestion
   inline constexpr std::string_view CUMULATIVE_TIME_SERIES_POLICY = "time_series";
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org