You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Patrick Hunt (JIRA)" <ji...@apache.org> on 2010/03/05 18:12:27 UTC
[jira] Created: (ZOOKEEPER-688) explain session expiration better
in the docs & faq
explain session expiration better in the docs & faq
---------------------------------------------------
Key: ZOOKEEPER-688
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-688
Project: Zookeeper
Issue Type: Bug
Components: documentation
Reporter: Patrick Hunt
Assignee: Benjamin Reed
Priority: Critical
Fix For: 3.3.0
We are not clear enough (and the diagram we do have seems misleading) on _when_ session expirations are generated. In particular the fact that you only get expirations when the client is connected to the cluster, not when disconnected.
we need to detail:
1) when do you get expiration
2) what is the sequence of events that the watcher sees, from disco state, to getting the expiration (say the expiration happens when the client is disco, what do you see in the watcher while you are getting reconnected)
3) we need to give some examples of how to test this. We should be explicit that "pulling the network cable" on the client will not show expiration since the cliient will not be reconnected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-688) explain session expiration better
in the docs & faq
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-688:
------------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. thanks pat!
> explain session expiration better in the docs & faq
> ---------------------------------------------------
>
> Key: ZOOKEEPER-688
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-688
> Project: Zookeeper
> Issue Type: Bug
> Components: documentation
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-688.patch, ZOOKEEPER-688.patch
>
>
> We are not clear enough (and the diagram we do have seems misleading) on _when_ session expirations are generated. In particular the fact that you only get expirations when the client is connected to the cluster, not when disconnected.
> we need to detail:
> 1) when do you get expiration
> 2) what is the sequence of events that the watcher sees, from disco state, to getting the expiration (say the expiration happens when the client is disco, what do you see in the watcher while you are getting reconnected)
> 3) we need to give some examples of how to test this. We should be explicit that "pulling the network cable" on the client will not show expiration since the cliient will not be reconnected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-688) explain session expiration better
in the docs & faq
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt reassigned ZOOKEEPER-688:
--------------------------------------
Assignee: Patrick Hunt (was: Benjamin Reed)
> explain session expiration better in the docs & faq
> ---------------------------------------------------
>
> Key: ZOOKEEPER-688
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-688
> Project: Zookeeper
> Issue Type: Bug
> Components: documentation
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-688.patch
>
>
> We are not clear enough (and the diagram we do have seems misleading) on _when_ session expirations are generated. In particular the fact that you only get expirations when the client is connected to the cluster, not when disconnected.
> we need to detail:
> 1) when do you get expiration
> 2) what is the sequence of events that the watcher sees, from disco state, to getting the expiration (say the expiration happens when the client is disco, what do you see in the watcher while you are getting reconnected)
> 3) we need to give some examples of how to test this. We should be explicit that "pulling the network cable" on the client will not show expiration since the cliient will not be reconnected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-688) explain session expiration better
in the docs & faq
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-688:
-----------------------------------
Status: Patch Available (was: Open)
I added more detail on how session expiration works.
> explain session expiration better in the docs & faq
> ---------------------------------------------------
>
> Key: ZOOKEEPER-688
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-688
> Project: Zookeeper
> Issue Type: Bug
> Components: documentation
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-688.patch
>
>
> We are not clear enough (and the diagram we do have seems misleading) on _when_ session expirations are generated. In particular the fact that you only get expirations when the client is connected to the cluster, not when disconnected.
> we need to detail:
> 1) when do you get expiration
> 2) what is the sequence of events that the watcher sees, from disco state, to getting the expiration (say the expiration happens when the client is disco, what do you see in the watcher while you are getting reconnected)
> 3) we need to give some examples of how to test this. We should be explicit that "pulling the network cable" on the client will not show expiration since the cliient will not be reconnected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-688) explain session expiration better
in the docs & faq
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-688:
------------------------------------
Attachment: ZOOKEEPER-688.patch
just updated the patch with minor changes on automatic reconnects by the client library.
> explain session expiration better in the docs & faq
> ---------------------------------------------------
>
> Key: ZOOKEEPER-688
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-688
> Project: Zookeeper
> Issue Type: Bug
> Components: documentation
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-688.patch, ZOOKEEPER-688.patch
>
>
> We are not clear enough (and the diagram we do have seems misleading) on _when_ session expirations are generated. In particular the fact that you only get expirations when the client is connected to the cluster, not when disconnected.
> we need to detail:
> 1) when do you get expiration
> 2) what is the sequence of events that the watcher sees, from disco state, to getting the expiration (say the expiration happens when the client is disco, what do you see in the watcher while you are getting reconnected)
> 3) we need to give some examples of how to test this. We should be explicit that "pulling the network cable" on the client will not show expiration since the cliient will not be reconnected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-688) explain session expiration better
in the docs & faq
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12842046#action_12842046 ]
Mahadev konar commented on ZOOKEEPER-688:
-----------------------------------------
+1 for the patch. Ill update the FAQ to match whats on the forrest docs.
> explain session expiration better in the docs & faq
> ---------------------------------------------------
>
> Key: ZOOKEEPER-688
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-688
> Project: Zookeeper
> Issue Type: Bug
> Components: documentation
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-688.patch, ZOOKEEPER-688.patch
>
>
> We are not clear enough (and the diagram we do have seems misleading) on _when_ session expirations are generated. In particular the fact that you only get expirations when the client is connected to the cluster, not when disconnected.
> we need to detail:
> 1) when do you get expiration
> 2) what is the sequence of events that the watcher sees, from disco state, to getting the expiration (say the expiration happens when the client is disco, what do you see in the watcher while you are getting reconnected)
> 3) we need to give some examples of how to test this. We should be explicit that "pulling the network cable" on the client will not show expiration since the cliient will not be reconnected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-688) explain session expiration better
in the docs & faq
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12842242#action_12842242 ]
Hudson commented on ZOOKEEPER-688:
----------------------------------
Integrated in ZooKeeper-trunk #716 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/716/])
. explain session expiration better in the docs & faq (phunt via mahadev)
> explain session expiration better in the docs & faq
> ---------------------------------------------------
>
> Key: ZOOKEEPER-688
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-688
> Project: Zookeeper
> Issue Type: Bug
> Components: documentation
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-688.patch, ZOOKEEPER-688.patch
>
>
> We are not clear enough (and the diagram we do have seems misleading) on _when_ session expirations are generated. In particular the fact that you only get expirations when the client is connected to the cluster, not when disconnected.
> we need to detail:
> 1) when do you get expiration
> 2) what is the sequence of events that the watcher sees, from disco state, to getting the expiration (say the expiration happens when the client is disco, what do you see in the watcher while you are getting reconnected)
> 3) we need to give some examples of how to test this. We should be explicit that "pulling the network cable" on the client will not show expiration since the cliient will not be reconnected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-688) explain session expiration better
in the docs & faq
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-688:
-----------------------------------
Attachment: ZOOKEEPER-688.patch
> explain session expiration better in the docs & faq
> ---------------------------------------------------
>
> Key: ZOOKEEPER-688
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-688
> Project: Zookeeper
> Issue Type: Bug
> Components: documentation
> Reporter: Patrick Hunt
> Assignee: Benjamin Reed
> Priority: Critical
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-688.patch
>
>
> We are not clear enough (and the diagram we do have seems misleading) on _when_ session expirations are generated. In particular the fact that you only get expirations when the client is connected to the cluster, not when disconnected.
> we need to detail:
> 1) when do you get expiration
> 2) what is the sequence of events that the watcher sees, from disco state, to getting the expiration (say the expiration happens when the client is disco, what do you see in the watcher while you are getting reconnected)
> 3) we need to give some examples of how to test this. We should be explicit that "pulling the network cable" on the client will not show expiration since the cliient will not be reconnected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-688) explain session expiration better
in the docs & faq
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841970#action_12841970 ]
Hadoop QA commented on ZOOKEEPER-688:
-------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12438030/ZOOKEEPER-688.patch
against trunk revision 919280.
+1 @author. The patch does not contain any @author tags.
+0 tests included. The patch appears to be a documentation patch that doesn't require tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/128/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/128/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/128/console
This message is automatically generated.
> explain session expiration better in the docs & faq
> ---------------------------------------------------
>
> Key: ZOOKEEPER-688
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-688
> Project: Zookeeper
> Issue Type: Bug
> Components: documentation
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-688.patch
>
>
> We are not clear enough (and the diagram we do have seems misleading) on _when_ session expirations are generated. In particular the fact that you only get expirations when the client is connected to the cluster, not when disconnected.
> we need to detail:
> 1) when do you get expiration
> 2) what is the sequence of events that the watcher sees, from disco state, to getting the expiration (say the expiration happens when the client is disco, what do you see in the watcher while you are getting reconnected)
> 3) we need to give some examples of how to test this. We should be explicit that "pulling the network cable" on the client will not show expiration since the cliient will not be reconnected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.