You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "Martin Ritchie (JIRA)" <ji...@apache.org> on 2006/11/15 15:28:44 UTC
[jira] Created: (DIRMINA-307) ReadThrottleFilterBuilder does not
resume reading.
ReadThrottleFilterBuilder does not resume reading.
--------------------------------------------------
Key: DIRMINA-307
URL: http://issues.apache.org/jira/browse/DIRMINA-307
Project: Directory MINA
Issue Type: Bug
Components: Filter
Affects Versions: 1.0
Reporter: Martin Ritchie
Priority: Blocker
The starvation problems being experienced by testing of the MultiThreadedSocketIOProcessor(DIRMINA-301) are related to this bug.
When using multiple threads the the removeal of attribute SUSPENDED_READS is not done after resuming reads it is done on any and all calls to release.
The session.removeAttribute( SUSPENDED_READS ); line should be moved inside the if statement.
in method release:
if( counter < maximumConnectionBufferSize && isSuspendedReads( session ) )
{
session.resumeRead();
session.removeAttribute( SUSPENDED_READS );
}
Patch is attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (DIRMINA-307) ReadThrottleFilterBuilder does not
resume reading.
Posted by "Martin Ritchie (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/DIRMINA-307?page=all ]
Martin Ritchie closed DIRMINA-307.
----------------------------------
Thanks Trustin.
> ReadThrottleFilterBuilder does not resume reading.
> --------------------------------------------------
>
> Key: DIRMINA-307
> URL: http://issues.apache.org/jira/browse/DIRMINA-307
> Project: MINA
> Issue Type: Bug
> Components: Filter
> Affects Versions: 1.0
> Reporter: Martin Ritchie
> Assigned To: Trustin Lee
> Priority: Blocker
> Fix For: 1.0.1
>
> Attachments: ReadThrottleFilterBuilder.patch
>
>
> The starvation problems being experienced by testing of the MultiThreadedSocketIOProcessor(DIRMINA-301) are related to this bug.
> When using multiple threads the the removeal of attribute SUSPENDED_READS is not done after resuming reads it is done on any and all calls to release.
> The session.removeAttribute( SUSPENDED_READS ); line should be moved inside the if statement.
> in method release:
> if( counter < maximumConnectionBufferSize && isSuspendedReads( session ) )
> {
> session.resumeRead();
> session.removeAttribute( SUSPENDED_READS );
> }
> Patch is attached.
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DIRMINA-307) ReadThrottleFilterBuilder does not
resume reading.
Posted by "Martin Ritchie (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/DIRMINA-307?page=all ]
Martin Ritchie updated DIRMINA-307:
-----------------------------------
Attachment: ReadThrottleFilterBuilder.patch
Here is the patch described in the bug
> ReadThrottleFilterBuilder does not resume reading.
> --------------------------------------------------
>
> Key: DIRMINA-307
> URL: http://issues.apache.org/jira/browse/DIRMINA-307
> Project: Directory MINA
> Issue Type: Bug
> Components: Filter
> Affects Versions: 1.0
> Reporter: Martin Ritchie
> Priority: Blocker
> Attachments: ReadThrottleFilterBuilder.patch
>
>
> The starvation problems being experienced by testing of the MultiThreadedSocketIOProcessor(DIRMINA-301) are related to this bug.
> When using multiple threads the the removeal of attribute SUSPENDED_READS is not done after resuming reads it is done on any and all calls to release.
> The session.removeAttribute( SUSPENDED_READS ); line should be moved inside the if statement.
> in method release:
> if( counter < maximumConnectionBufferSize && isSuspendedReads( session ) )
> {
> session.resumeRead();
> session.removeAttribute( SUSPENDED_READS );
> }
> Patch is attached.
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (DIRMINA-307) ReadThrottleFilterBuilder does not
resume reading.
Posted by "Trustin Lee (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/DIRMINA-307?page=all ]
Trustin Lee resolved DIRMINA-307.
---------------------------------
Fix Version/s: 1.0.1
Resolution: Fixed
Assignee: Trustin Lee
Your patch has been applied to all branches.
> ReadThrottleFilterBuilder does not resume reading.
> --------------------------------------------------
>
> Key: DIRMINA-307
> URL: http://issues.apache.org/jira/browse/DIRMINA-307
> Project: MINA
> Issue Type: Bug
> Components: Filter
> Affects Versions: 1.0
> Reporter: Martin Ritchie
> Assigned To: Trustin Lee
> Priority: Blocker
> Fix For: 1.0.1
>
> Attachments: ReadThrottleFilterBuilder.patch
>
>
> The starvation problems being experienced by testing of the MultiThreadedSocketIOProcessor(DIRMINA-301) are related to this bug.
> When using multiple threads the the removeal of attribute SUSPENDED_READS is not done after resuming reads it is done on any and all calls to release.
> The session.removeAttribute( SUSPENDED_READS ); line should be moved inside the if statement.
> in method release:
> if( counter < maximumConnectionBufferSize && isSuspendedReads( session ) )
> {
> session.resumeRead();
> session.removeAttribute( SUSPENDED_READS );
> }
> Patch is attached.
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira