You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/07/22 22:07:58 UTC

[GitHub] [commons-beanutils] SethFalco commented on a change in pull request #92: chore: fix warnings and todos

SethFalco commented on a change in pull request #92:
URL: https://github.com/apache/commons-beanutils/pull/92#discussion_r675194021



##########
File path: src/main/java/org/apache/commons/beanutils2/converters/SqlTimeConverter.java
##########
@@ -68,9 +68,7 @@ public SqlTimeConverter(final Object defaultValue) {
     }
 
     /**
-     * Gets a {@code DateFormat} for the Locale.
-     * @param locale TODO
-     * @param timeZone TODO
+     * {@inheritDoc}

Review comment:
       Valid 🤔 
   
   I remember at the time thinking I'll leave the `@return` tag because it was different, so I assumed it should be overridden.
   Now looking at it... I realize it's "different" but not actually different.
   
   I'll remove it. ^-^'
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org