[GitHub] [nifi] markobean commented on pull request #6035: NIFI-9440 Allow Controller Services to have configurable Bulletins

[GitBox <gi...@apache.org>]

markobean commented on PR #6035:
URL: https://github.com/apache/nifi/pull/6035#issuecomment-1131972414

   This looks really good. I could find nothing wrong with the expected behavior as well as compatibility issues which were well-thought out. Here are some of the tests I performed:
   
   Changed this PR's code to modify a controller service (CS), specifically CSVReader, to issue DEBUG, INFO, WARN and ERROR log messages when enabled. Built and installed.
   
   Instantiated CSVReader within a process group (PG) and set the Bulletin Level to DEBUG
   Enabled the CS and observed all four bulletins on the PG's listing of Controller Services. Also observed them on the Bulletin Board.
   Repeat, changing the Bulletin Level to INFO, then WARN, then ERROR. All confirmed to behave as expected with bulletin visibility.
   
   Copy/paste the PG. 
    > The bulletin level for the CS remained as DEBUG, and behavior confirmed.
   
   Version controlled the PG to NiFi Registry of this PR (1.17.0-SNAPSHOT). Then, instantiated the flow from Registry.
    > The bulletin level for the CS remained as DEBUG, and behavior confirmed.
   
   Version controlled the PG to NiFi Registry, 1.16.1. Then, instantiated the flow from Registry.
    > The bulletin level for the CS returned to WARN as expected, and corresponding behavior confirmed.
   
   For backward compatibility, installed NiFi 1.16.1 placing flow.xml.gz and flow.json.gz in the conf directory (and other required config updates to enable NIFi to start.) NiFi started without issue. CS issued bulletins at the WARN level.
   
   The only comment is that TRACE is not an option. However, it is not a Bulletin Level option for processors either, so I think this is fine. If you're interested in TRACE level, you're probably looking at - or have the ability to look at - the log file directly.
   
   +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org