You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by su...@apache.org on 2019/07/02 06:45:15 UTC
[hadoop] branch branch-3.2 updated: YARN-9327. Improve
synchronisation in ProtoUtils#convertToProtoFormat block. Contributed by
Bibin A Chundatt.
This is an automated email from the ASF dual-hosted git repository.
sunilg pushed a commit to branch branch-3.2
in repository https://gitbox.apache.org/repos/asf/hadoop.git
The following commit(s) were added to refs/heads/branch-3.2 by this push:
new bea79e7 YARN-9327. Improve synchronisation in ProtoUtils#convertToProtoFormat block. Contributed by Bibin A Chundatt.
bea79e7 is described below
commit bea79e7645b15ccf69b71b457be7e62848f2e37b
Author: Sunil G <su...@apache.org>
AuthorDate: Tue Jul 2 11:44:11 2019 +0530
YARN-9327. Improve synchronisation in ProtoUtils#convertToProtoFormat block. Contributed by Bibin A Chundatt.
(cherry picked from commit 0c8813f135f8c17f88660bb92529c15bb3a157ca)
---
.../java/org/apache/hadoop/yarn/api/records/impl/pb/ProtoUtils.java | 2 +-
.../org/apache/hadoop/yarn/api/records/impl/pb/ResourcePBImpl.java | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ProtoUtils.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ProtoUtils.java
index 76e86ad..3568a70 100644
--- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ProtoUtils.java
+++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ProtoUtils.java
@@ -400,7 +400,7 @@ public class ProtoUtils {
/*
* Resource
*/
- public static synchronized ResourceProto convertToProtoFormat(Resource r) {
+ public static ResourceProto convertToProtoFormat(Resource r) {
return ResourcePBImpl.getProto(r);
}
diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ResourcePBImpl.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ResourcePBImpl.java
index 144f48f..b2d63b4 100644
--- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ResourcePBImpl.java
+++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ResourcePBImpl.java
@@ -71,14 +71,14 @@ public class ResourcePBImpl extends Resource {
initResources();
}
- public ResourceProto getProto() {
+ synchronized public ResourceProto getProto() {
mergeLocalToProto();
proto = viaProto ? proto : builder.build();
viaProto = true;
return proto;
}
- private void maybeInitBuilder() {
+ synchronized private void maybeInitBuilder() {
if (viaProto || builder == null) {
builder = ResourceProto.newBuilder(proto);
}
@@ -127,7 +127,7 @@ public class ResourcePBImpl extends Resource {
resources[VCORES_INDEX].setValue(vCores);
}
- private void initResources() {
+ synchronized private void initResources() {
if (this.resources != null) {
return;
}
---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org