You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by "Aman-Mittal (via GitHub)" <gi...@apache.org> on 2026/09/06 07:32:56 UTC
[I] Two navigation icons are never registered with Ionicons, so they silently render as nothing [fineract-backoffice-ui]
Aman-Mittal opened a new issue, #485:
URL: https://github.com/apache/fineract-backoffice-ui/issues/485
## What happens
Two icons used by the navigation config fail to load on every page, warning twice per route:
```
[Ionicons Warning]: Could not load icon with name "flash-outline". Ensure that the icon is
registered using addIcons or that the icon SVG data is passed directly to the icon component.
[Ionicons Warning]: Could not load icon with name "checkmark-done-outline". ...
```
Wherever these are used, the `<ion-icon>` renders as empty space — no icon, no fallback, no visible error. It reads as a mildly misaligned label rather than a missing asset.
## Where they come from
Both names are referenced by the navigation config:
```
src/app/core/services/navigation-config.service.ts:638: icon: 'flash-outline',
src/app/core/services/navigation-config.service.ts:711: icon: 'checkmark-done-outline',
```
...and `addIcons` appears **nowhere** in `src/app`:
```console
$ grep -rn "addIcons" src/app --include=*.ts
(no matches)
```
So the app relies entirely on Ionicons' lazy CDN-style fetch by name. That is what the warning is complaining about, and it is also why the two failures are silent: the fetch fails and the component renders empty rather than surfacing an error.
This is the same subsystem as the `Failed to construct 'URL': Invalid base URL` exception that fires immediately before each of these warnings — that one is filed separately, but a fix that registers icons explicitly would likely resolve both.
## Suggested fix
Register the icon set explicitly with `addIcons({ flashOutline, checkmarkDoneOutline, ... })` from `ionicons/icons` at bootstrap, rather than depending on name-based lazy loading. That makes the icons resolve deterministically, removes the runtime fetch, and means a typo in a `navigation-config` icon name fails at build time instead of rendering blank in production.
At minimum, the two names above need to resolve to something.
## Environment
Reproduced against a clean checkout of `main` (`a24a06ba`) served with `ng serve`, Chrome. Both warnings fire on every route load, including a hard reload with cache disabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Two navigation icons are never registered with Ionicons, so they silently render as nothing [fineract-backoffice-ui]
Posted by "ryux1 (via GitHub)" <gi...@apache.org>.
ryux1 commented on issue #485:
URL: https://github.com/apache/fineract-backoffice-ui/issues/485#issuecomment-5557773304
I can take this. I confirmed the current registry and bootstrap path exist, but these two navigation-only names are absent and the current icon check only scans `<ion-icon>` bindings. I will register both icons and extend the existing check to cover static navigation icon names so this class of blank icon fails in CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Two navigation icons are never registered with Ionicons, so they silently render as nothing [fineract-backoffice-ui]
Posted by "Aman-Mittal (via GitHub)" <gi...@apache.org>.
Aman-Mittal closed issue #485: Two navigation icons are never registered with Ionicons, so they silently render as nothing
URL: https://github.com/apache/fineract-backoffice-ui/issues/485
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Two navigation icons are never registered with Ionicons, so they silently render as nothing [fineract-backoffice-ui]
Posted by "Aman-Mittal (via GitHub)" <gi...@apache.org>.
Aman-Mittal commented on issue #485:
URL: https://github.com/apache/fineract-backoffice-ui/issues/485#issuecomment-5558639847
Correcting the report now that this is closed, so it does not mislead anyone who finds it later.
The line "`addIcons` appears **nowhere** in `src/app`" is wrong. It is in `src/bootstrap.ts`, outside the path I grepped, and the app has an explicit icon registry — it does not rely on name-based lazy loading as I claimed. @ryux1 had it right in the comment above.
The symptom was real and the fix was the right one: `flash-outline` and `checkmark-done-outline` were simply missing from that registry, and `check-icons` only scanned `<ion-icon>` bindings, so a name set in `navigation-config.service.ts` was invisible to it. The "Suggested fix" section describing the whole approach as missing should be read as describing two absent entries, not an absent mechanism.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org