You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "DomGarguilo (via GitHub)" <gi...@apache.org> on 2023/02/10 21:43:16 UTC
[GitHub] [accumulo-proxy] DomGarguilo opened a new pull request, #74: Add tests for user creation/deletion and permissions granting/revoking
DomGarguilo opened a new pull request, #74:
URL: https://github.com/apache/accumulo-proxy/pull/74
This PR aims to add tests that cover the following:
1. The proxy's ability to create a user
2. The proxy's ability to execute the grant/revoke permission APIs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-proxy] ctubbsii commented on a diff in pull request #74: Add tests for user creation/deletion and permissions granting/revoking
Posted by "ctubbsii (via GitHub)" <gi...@apache.org>.
ctubbsii commented on code in PR #74:
URL: https://github.com/apache/accumulo-proxy/pull/74#discussion_r1103299863
##########
src/test/java/org/apache/accumulo/proxy/its/SimpleProxyBase.java:
##########
@@ -249,7 +249,8 @@ public static void setUpProxy() throws Exception {
} else {
clientPrincipal = "root";
tokenClass = PasswordToken.class.getName();
- sharedSecret = SharedMiniClusterBase.getRootPassword();
+ sharedSecret = "sharedSecret";
Review Comment:
I would make the value different from the key that's used in the config file... just to make sure that it's detectable if we accidentally read the key instead of the value or vice versa.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-proxy] DomGarguilo merged pull request #74: Add tests for user creation/deletion and permissions granting/revoking
Posted by "DomGarguilo (via GitHub)" <gi...@apache.org>.
DomGarguilo merged PR #74:
URL: https://github.com/apache/accumulo-proxy/pull/74
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org