You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/11/25 19:33:18 UTC
[GitHub] [helix] xyuanlu opened a new pull request #1560: fix test Helix-rest testAddConfigFields
xyuanlu opened a new pull request #1560:
URL: https://github.com/apache/helix/pull/1560
### Issues
- [X] My PR addresses the following Helix issues and references them in the PR description:
#1336
### Description
- [X] Here are some details about my PR, including screenshots of any UI changes:
The test is constantly failing on master now. The direct reason is the same, there is an empty INSTANCE_CAPACITY_KEYS=[], list so we get a IndexOutOfBoundsException error.
My theory is that, this empty list could be added by TestInstancesAccessor.testValidateWeightForAllInstances() or TestPerInstanceAccessor.testValidateWeightForInstance() since these two tests and TestClusterAccessor.testUpdateConfigFields() uses the same cluster "TestCluster_0".
In the test log where testUpdateConfigFields is failing, the two tests that added this empty list always happens before this testUpdateConfigFields.
My solution is simply changing the cluster for testUpdateConfigFields to another test cluster and use "TestCluster_0" only for WAGED related tests.
### Tests
- [X] The following tests are written for this issue:
NA
- [X] The following is the result of the "mvn test" command on the appropriate module:
```
[INFO] Tests run: 171, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 246.815 s - in TestSuite
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 171, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 04:10 min
[INFO] Finished at: 2020-11-25T11:20:46-08:00
[INFO] ------------------------------------------------------------------------
```
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] dasahcc merged pull request #1560: fix test Helix-rest testAddConfigFields
Posted by GitBox <gi...@apache.org>.
dasahcc merged pull request #1560:
URL: https://github.com/apache/helix/pull/1560
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] xyuanlu commented on pull request #1560: fix test Helix-rest testAddConfigFields
Posted by GitBox <gi...@apache.org>.
xyuanlu commented on pull request #1560:
URL: https://github.com/apache/helix/pull/1560#issuecomment-738993687
This PR is ready to be merged. Approved by @kaisun2000
Final commit message:
Fix test Helix-rest testAddConfigFields
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] xyuanlu commented on a change in pull request #1560: fix test Helix-rest testAddConfigFields
Posted by GitBox <gi...@apache.org>.
xyuanlu commented on a change in pull request #1560:
URL: https://github.com/apache/helix/pull/1560#discussion_r533742079
##########
File path: helix-rest/src/test/java/org/apache/helix/rest/server/TestClusterAccessor.java
##########
@@ -224,7 +224,7 @@ public void testGetClusterTopologyAndFaultZoneMap() throws IOException {
@Test(dependsOnMethods = "testGetClusterTopologyAndFaultZoneMap")
public void testAddConfigFields() throws IOException {
System.out.println("Start test :" + TestHelper.getTestMethodName());
- String cluster = _clusters.iterator().next();
+ String cluster = "TestCluster_1";
Review comment:
TFTR. I think adding more description for these clusters might be a better option here. Let me update.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] zhangmeng916 commented on a change in pull request #1560: fix test Helix-rest testAddConfigFields
Posted by GitBox <gi...@apache.org>.
zhangmeng916 commented on a change in pull request #1560:
URL: https://github.com/apache/helix/pull/1560#discussion_r533086778
##########
File path: helix-rest/src/test/java/org/apache/helix/rest/server/TestClusterAccessor.java
##########
@@ -224,7 +224,7 @@ public void testGetClusterTopologyAndFaultZoneMap() throws IOException {
@Test(dependsOnMethods = "testGetClusterTopologyAndFaultZoneMap")
public void testAddConfigFields() throws IOException {
System.out.println("Start test :" + TestHelper.getTestMethodName());
- String cluster = _clusters.iterator().next();
+ String cluster = "TestCluster_1";
Review comment:
This fix could work, but it is not very intuitive for writing future tests. People may easily overlook the guideline. Do you think it's possible to reset the cluster back to normal after waged related tests? If it's not feasible, we may want to add more description for this guideline or not to name it simply as 0, 1, 2.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org