You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/11/27 12:52:04 UTC

[GitHub] [iceberg] felixYyu opened a new issue #3615: Why use DistributionAndOrderingUtils$ to import?

felixYyu opened a new issue #3615:
URL: https://github.com/apache/iceberg/issues/3615


   in Spark3SortStrategy class file
   import org.apache.spark.sql.catalyst.utils.DistributionAndOrderingUtils$;
   protected LogicalPlan sortPlan(Distribution distribution, SortOrder[] ordering, LogicalPlan plan, SQLConf conf) {
       return DistributionAndOrderingUtils$.MODULE$.prepareQuery(distribution, ordering, plan, conf);
   }
   '$' has been used, why
   ------------------------------------------------------------------------------------------------------------
   import org.apache.spark.sql.catalyst.utils.DistributionAndOrderingUtils;
   protected LogicalPlan sortPlan(Distribution distribution, SortOrder[] ordering, LogicalPlan plan, SQLConf conf) {
       return DistributionAndOrderingUtils.prepareQuery(distribution, ordering, plan, conf);
   }
   this format is also right?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] felixYyu commented on issue #3615: Why use DistributionAndOrderingUtils$ to import?

Posted by GitBox <gi...@apache.org>.
felixYyu commented on issue #3615:
URL: https://github.com/apache/iceberg/issues/3615#issuecomment-980966600


   cc @rdblue @RussellSpitzer 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] felixYyu closed issue #3615: Why use DistributionAndOrderingUtils$ to import?

Posted by GitBox <gi...@apache.org>.
felixYyu closed issue #3615:
URL: https://github.com/apache/iceberg/issues/3615


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] felixYyu commented on issue #3615: Why use DistributionAndOrderingUtils$ to import?

Posted by GitBox <gi...@apache.org>.
felixYyu commented on issue #3615:
URL: https://github.com/apache/iceberg/issues/3615#issuecomment-985966213


   thanks Russell replay, I get.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] RussellSpitzer commented on issue #3615: Why use DistributionAndOrderingUtils$ to import?

Posted by GitBox <gi...@apache.org>.
RussellSpitzer commented on issue #3615:
URL: https://github.com/apache/iceberg/issues/3615#issuecomment-982249435


   This is one of those fun things about Java Scala interoperability. Scala compiles .scala files into several Java classes depending on their usage. Singleton's and Static methods end up getting placed in a Class$.MODULE$ java class, so if we want to access the methods from a Scala `object` we need to use these weird $'s. I'm not sure if there is a way to make Scala compile it into a singleton with the same class name without $ but I just always use $.MODULE$ when I'm interoperating with Scala singletons from Java.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org