You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/03/28 02:39:55 UTC

[GitHub] [incubator-mxnet] reminisce commented on a change in pull request #14113: Enhance subgraph API

reminisce commented on a change in pull request #14113: Enhance subgraph API
URL: https://github.com/apache/incubator-mxnet/pull/14113#discussion_r269837846
 
 

 ##########
 File path: src/operator/subgraph/build_subgraph.cc
 ##########
 @@ -101,12 +68,12 @@ void PrintNodeEntries(const std::vector<nnvm::NodeEntry*>& entries) {
  * \param g the MXNet computational graph
  * \param simple_nodes the nodes of undirected graph in top sorted order
  */
-void CreateSimpleGraph(const Graph& g,
-                       std::vector<SimpleNodePtr>* simple_nodes) {
+void CreateSimpleGraph(const nnvm::Graph& g,
+                       std::vector<BiDirectionalNodePtr>* simple_nodes) {
 
 Review comment:
   BiDirectional -> BiDirected is more appropriate.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services