You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by Sahoo <sa...@oracle.com> on 2011/01/20 14:06:26 UTC
[VOTE] Release Apache Felix FileInstall version 3.1.6
Hi,
We solved 1 issue in this release:
** Bug
* [FELIX-2791] - NPE in getStartLevel due to race condition
Staging repository:
https://repository.apache.org/content/repositories/orgapachefelix-057/
You can use this UNIX script to download the release and verify the
signatures:
http://svn.apache.org/repos/asf/felix/trunk/check_staged_release.sh
Usage:
sh check_staged_release.sh 057 /tmp/felix-staging
Please vote to approve this release:
[ ] +1 Approve the release
[ ] -1 Veto the release (please provide specific comments)
This vote will be open for 72 hours.
Thanks,
Sahoo
Re: [VOTE] Release Apache Felix FileInstall version 3.1.6
Posted by "Richard S. Hall" <he...@ungoverned.org>.
+1
-> richard
On 1/20/11 8:06, Sahoo wrote:
> Hi,
>
> We solved 1 issue in this release:
>
> ** Bug
> * [FELIX-2791] - NPE in getStartLevel due to race condition
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachefelix-057/
>
> You can use this UNIX script to download the release and verify the
> signatures:
> http://svn.apache.org/repos/asf/felix/trunk/check_staged_release.sh
>
> Usage:
> sh check_staged_release.sh 057 /tmp/felix-staging
>
> Please vote to approve this release:
>
> [ ] +1 Approve the release
> [ ] -1 Veto the release (please provide specific comments)
>
> This vote will be open for 72 hours.
>
> Thanks,
> Sahoo
Re: [VOTE] Release Apache Felix FileInstall version 3.1.6
Posted by Guillaume Nodet <gn...@gmail.com>.
+1
On Thu, Jan 20, 2011 at 14:06, Sahoo <sa...@oracle.com> wrote:
> Hi,
>
> We solved 1 issue in this release:
>
> ** Bug
> * [FELIX-2791] - NPE in getStartLevel due to race condition
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachefelix-057/
>
> You can use this UNIX script to download the release and verify the
> signatures:
> http://svn.apache.org/repos/asf/felix/trunk/check_staged_release.sh
>
> Usage:
> sh check_staged_release.sh 057 /tmp/felix-staging
>
> Please vote to approve this release:
>
> [ ] +1 Approve the release
> [ ] -1 Veto the release (please provide specific comments)
>
> This vote will be open for 72 hours.
>
> Thanks,
> Sahoo
>
--
Cheers,
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
Open Source SOA
http://fusesource.com
Re: [DICUSS] Release Apache Felix FileInstall version 3.1.6
Posted by Guillaume Nodet <gn...@gmail.com>.
I've checked in my changes, so I'll cut a 3.1.8 release tomorrow.
On Mon, Jan 24, 2011 at 14:28, Sahoo <sa...@oracle.com> wrote:
> On Monday 24 January 2011 06:32 PM, Guillaume Nodet wrote:
>>
>> Anyway that's really not big of a deal.
>>
>> FWIW, I have another bug fix i really need which is FELIX-2798 so in
>> all cases, I'll recut a 3.1.8 release this week (unless that one is
>> cancelled for whatever reason).
>>
>>
>
> Well, I need 3.1.6 at the earliest for it to be integrated in GlassFish. I
> would like to avoid waiting for 3.1.8.
>
> Sahoo
>
--
Cheers,
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
Open Source SOA
http://fusesource.com
Re: [DICUSS] Release Apache Felix FileInstall version 3.1.6
Posted by Sahoo <sa...@oracle.com>.
On Monday 24 January 2011 06:32 PM, Guillaume Nodet wrote:
> Anyway that's really not big of a deal.
>
> FWIW, I have another bug fix i really need which is FELIX-2798 so in
> all cases, I'll recut a 3.1.8 release this week (unless that one is
> cancelled for whatever reason).
>
>
Well, I need 3.1.6 at the earliest for it to be integrated in GlassFish.
I would like to avoid waiting for 3.1.8.
Sahoo
Re: [DICUSS] Release Apache Felix FileInstall version 3.1.6
Posted by Guillaume Nodet <gn...@gmail.com>.
On Mon, Jan 24, 2011 at 13:54, Sahoo <sa...@oracle.com> wrote:
> On Monday 24 January 2011 02:34 PM, Guillaume Nodet wrote:
>>
>> On Mon, Jan 24, 2011 at 09:49, Sahoo<sa...@oracle.com> wrote:
>>
>>>
>>> wait(0) causes a thread to wait until notified or interrupted, so why
>>> why should any CPU cycles be wasted?
>>>
>>
>> You're right, forget about that.
>>
>>
>>>
>>> Secondly, can you also tell me why
>>> you think it is artificial? Can't the instructions be reordered such
>>> that the watcher threads start before initialization is complete?
>>>
>>
>> Everything comes down to the fact that the ConfigAdmin support is
>> started before the other trackers are created and opened IIUC, so on
>> the JIRA issue, I suggested to simply move that part to the end of the
>> initialization, so that no DirectoryWatcher threads can be started
>> before everything is set up. I think that would solve the problem in
>> a cleaner way.
>>
>>
>
> We can't rely on program order being same as the execution order in a
> multi-threaded environment, can we? So, an explicit barrier is a much better
> way to guarantee that watcher threads don't run before initialization of
> fileinstall is complete.
>
In that case, the activator is called and watcher threads are only
created (indirectly) because it registers the ConfigAdmin
ManagedService in the OSGi registry, so until the activator does so,
there is only a single thread running. It would have been sufficient
to just make sure everything is initialized before starting spawning
threads (by registering the CM support of calling update(xxx)
Anyway that's really not big of a deal.
FWIW, I have another bug fix i really need which is FELIX-2798 so in
all cases, I'll recut a 3.1.8 release this week (unless that one is
cancelled for whatever reason).
> Sahoo
>
--
Cheers,
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
Open Source SOA
http://fusesource.com
Re: [DICUSS] Release Apache Felix FileInstall version 3.1.6
Posted by Sahoo <sa...@oracle.com>.
On Monday 24 January 2011 02:34 PM, Guillaume Nodet wrote:
> On Mon, Jan 24, 2011 at 09:49, Sahoo<sa...@oracle.com> wrote:
>
>> wait(0) causes a thread to wait until notified or interrupted, so why
>> why should any CPU cycles be wasted?
>>
> You're right, forget about that.
>
>
>> Secondly, can you also tell me why
>> you think it is artificial? Can't the instructions be reordered such
>> that the watcher threads start before initialization is complete?
>>
> Everything comes down to the fact that the ConfigAdmin support is
> started before the other trackers are created and opened IIUC, so on
> the JIRA issue, I suggested to simply move that part to the end of the
> initialization, so that no DirectoryWatcher threads can be started
> before everything is set up. I think that would solve the problem in
> a cleaner way.
>
>
We can't rely on program order being same as the execution order in a
multi-threaded environment, can we? So, an explicit barrier is a much
better way to guarantee that watcher threads don't run before
initialization of fileinstall is complete.
Sahoo
Re: [DICUSS] Release Apache Felix FileInstall version 3.1.6
Posted by Guillaume Nodet <gn...@gmail.com>.
On Mon, Jan 24, 2011 at 09:49, Sahoo <sa...@oracle.com> wrote:
> wait(0) causes a thread to wait until notified or interrupted, so why
> why should any CPU cycles be wasted?
You're right, forget about that.
> Secondly, can you also tell me why
> you think it is artificial? Can't the instructions be reordered such
> that the watcher threads start before initialization is complete?
Everything comes down to the fact that the ConfigAdmin support is
started before the other trackers are created and opened IIUC, so on
the JIRA issue, I suggested to simply move that part to the end of the
initialization, so that no DirectoryWatcher threads can be started
before everything is set up. I think that would solve the problem in
a cleaner way.
>
> Sahoo
>
> On Monday 24 January 2011 12:54 PM, Guillaume Nodet wrote:
>> I don't really like this solution of introducing an artifical and
>> unneeded lock, as reordering the initialization in the activator
>> should work better imho.
>>
>> Anyway, wouldn't the loop with wait(0) spin the CPU at 100% in case we
>> hit this issue ?
>>
>> On Thu, Jan 20, 2011 at 14:06, Sahoo<sa...@oracle.com> wrote:
>>
>>> Hi,
>>>
>>> We solved 1 issue in this release:
>>>
>>> ** Bug
>>> * [FELIX-2791] - NPE in getStartLevel due to race condition
>>>
>>> Staging repository:
>>> https://repository.apache.org/content/repositories/orgapachefelix-057/
>>>
>>> You can use this UNIX script to download the release and verify the
>>> signatures:
>>> http://svn.apache.org/repos/asf/felix/trunk/check_staged_release.sh
>>>
>>> Usage:
>>> sh check_staged_release.sh 057 /tmp/felix-staging
>>>
>>> Please vote to approve this release:
>>>
>>> [ ] +1 Approve the release
>>> [ ] -1 Veto the release (please provide specific comments)
>>>
>>> This vote will be open for 72 hours.
>>>
>>> Thanks,
>>> Sahoo
>>>
>>>
>>
>>
>>
>
>
--
Cheers,
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
Open Source SOA
http://fusesource.com
Re: [DICUSS] Release Apache Felix FileInstall version 3.1.6
Posted by Sahoo <sa...@oracle.com>.
wait(0) causes a thread to wait until notified or interrupted, so why
why should any CPU cycles be wasted? Secondly, can you also tell me why
you think it is artificial? Can't the instructions be reordered such
that the watcher threads start before initialization is complete?
Sahoo
On Monday 24 January 2011 12:54 PM, Guillaume Nodet wrote:
> I don't really like this solution of introducing an artifical and
> unneeded lock, as reordering the initialization in the activator
> should work better imho.
>
> Anyway, wouldn't the loop with wait(0) spin the CPU at 100% in case we
> hit this issue ?
>
> On Thu, Jan 20, 2011 at 14:06, Sahoo<sa...@oracle.com> wrote:
>
>> Hi,
>>
>> We solved 1 issue in this release:
>>
>> ** Bug
>> * [FELIX-2791] - NPE in getStartLevel due to race condition
>>
>> Staging repository:
>> https://repository.apache.org/content/repositories/orgapachefelix-057/
>>
>> You can use this UNIX script to download the release and verify the
>> signatures:
>> http://svn.apache.org/repos/asf/felix/trunk/check_staged_release.sh
>>
>> Usage:
>> sh check_staged_release.sh 057 /tmp/felix-staging
>>
>> Please vote to approve this release:
>>
>> [ ] +1 Approve the release
>> [ ] -1 Veto the release (please provide specific comments)
>>
>> This vote will be open for 72 hours.
>>
>> Thanks,
>> Sahoo
>>
>>
>
>
>
[DICUSS] Release Apache Felix FileInstall version 3.1.6
Posted by Guillaume Nodet <gn...@gmail.com>.
I don't really like this solution of introducing an artifical and
unneeded lock, as reordering the initialization in the activator
should work better imho.
Anyway, wouldn't the loop with wait(0) spin the CPU at 100% in case we
hit this issue ?
On Thu, Jan 20, 2011 at 14:06, Sahoo <sa...@oracle.com> wrote:
> Hi,
>
> We solved 1 issue in this release:
>
> ** Bug
> * [FELIX-2791] - NPE in getStartLevel due to race condition
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachefelix-057/
>
> You can use this UNIX script to download the release and verify the
> signatures:
> http://svn.apache.org/repos/asf/felix/trunk/check_staged_release.sh
>
> Usage:
> sh check_staged_release.sh 057 /tmp/felix-staging
>
> Please vote to approve this release:
>
> [ ] +1 Approve the release
> [ ] -1 Veto the release (please provide specific comments)
>
> This vote will be open for 72 hours.
>
> Thanks,
> Sahoo
>
--
Cheers,
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
Open Source SOA
http://fusesource.com
Re: [VOTE] Release Apache Felix FileInstall version 3.1.6
Posted by Sahoo <sa...@oracle.com>.
+1
On Thursday 20 January 2011 06:36 PM, Sahoo wrote:
>
> [ ] +1 Approve the release
Re: [VOTE] Release Apache Felix FileInstall version 3.1.6
Posted by "Richard S. Hall" <he...@ungoverned.org>.
On 1/23/11 14:38, Richard S. Hall wrote:
> On 1/23/11 13:21, Sahoo wrote:
>> I am waiting for at least three votes to make the release...
>
> It's generally not a good idea to call a vote over a weekend...
I should have said, if you are expecting to be able to close the vote in
72 hours...remember that 72 hours is the minimum, not the maximum...
I should get to it by tomorrow...
-> richard
>> On Thursday 20 January 2011 06:36 PM, Sahoo wrote:
>>> Hi,
>>>
>>> We solved 1 issue in this release:
>>>
>>> ** Bug
>>> * [FELIX-2791] - NPE in getStartLevel due to race condition
>>>
>>> Staging repository:
>>> https://repository.apache.org/content/repositories/orgapachefelix-057/
>>>
>>> You can use this UNIX script to download the release and verify the
>>> signatures:
>>> http://svn.apache.org/repos/asf/felix/trunk/check_staged_release.sh
>>>
>>> Usage:
>>> sh check_staged_release.sh 057 /tmp/felix-staging
>>>
>>> Please vote to approve this release:
>>>
>>> [ ] +1 Approve the release
>>> [ ] -1 Veto the release (please provide specific comments)
>>>
>>> This vote will be open for 72 hours.
>>>
>>> Thanks,
>>> Sahoo
>>
Re: [VOTE] Release Apache Felix FileInstall version 3.1.6
Posted by "Richard S. Hall" <he...@ungoverned.org>.
On 1/23/11 13:21, Sahoo wrote:
> I am waiting for at least three votes to make the release...
It's generally not a good idea to call a vote over a weekend...
-> richard
>
> On Thursday 20 January 2011 06:36 PM, Sahoo wrote:
>> Hi,
>>
>> We solved 1 issue in this release:
>>
>> ** Bug
>> * [FELIX-2791] - NPE in getStartLevel due to race condition
>>
>> Staging repository:
>> https://repository.apache.org/content/repositories/orgapachefelix-057/
>>
>> You can use this UNIX script to download the release and verify the
>> signatures:
>> http://svn.apache.org/repos/asf/felix/trunk/check_staged_release.sh
>>
>> Usage:
>> sh check_staged_release.sh 057 /tmp/felix-staging
>>
>> Please vote to approve this release:
>>
>> [ ] +1 Approve the release
>> [ ] -1 Veto the release (please provide specific comments)
>>
>> This vote will be open for 72 hours.
>>
>> Thanks,
>> Sahoo
>
Re: [VOTE] Release Apache Felix FileInstall version 3.1.6
Posted by Sahoo <sa...@oracle.com>.
I am waiting for at least three votes to make the release...
On Thursday 20 January 2011 06:36 PM, Sahoo wrote:
> Hi,
>
> We solved 1 issue in this release:
>
> ** Bug
> * [FELIX-2791] - NPE in getStartLevel due to race condition
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachefelix-057/
>
> You can use this UNIX script to download the release and verify the
> signatures:
> http://svn.apache.org/repos/asf/felix/trunk/check_staged_release.sh
>
> Usage:
> sh check_staged_release.sh 057 /tmp/felix-staging
>
> Please vote to approve this release:
>
> [ ] +1 Approve the release
> [ ] -1 Veto the release (please provide specific comments)
>
> This vote will be open for 72 hours.
>
> Thanks,
> Sahoo
Re: [VOTE] Release Apache Felix FileInstall version 3.1.6
Posted by Karl Pauls <ka...@gmail.com>.
+1
regards,
Karl
On Mon, Jan 24, 2011 at 7:11 PM, Clement Escoffier
<cl...@gmail.com> wrote:
> +1,
>
> Regards,
>
> Clement
>
> PS: Thanks for fixing that one, I got the same issue...
>
> On 20.01.11 14:06, "Sahoo" <sa...@oracle.com> wrote:
>
>>Hi,
>>
>>We solved 1 issue in this release:
>>
>>** Bug
>> * [FELIX-2791] - NPE in getStartLevel due to race condition
>>
>>Staging repository:
>>https://repository.apache.org/content/repositories/orgapachefelix-057/
>>
>>You can use this UNIX script to download the release and verify the
>>signatures:
>>http://svn.apache.org/repos/asf/felix/trunk/check_staged_release.sh
>>
>>Usage:
>>sh check_staged_release.sh 057 /tmp/felix-staging
>>
>>Please vote to approve this release:
>>
>>[ ] +1 Approve the release
>>[ ] -1 Veto the release (please provide specific comments)
>>
>>This vote will be open for 72 hours.
>>
>>Thanks,
>>Sahoo
>
>
>
--
Karl Pauls
karlpauls@gmail.com
Re: [VOTE] Release Apache Felix FileInstall version 3.1.6
Posted by Clement Escoffier <cl...@gmail.com>.
+1,
Regards,
Clement
PS: Thanks for fixing that one, I got the same issue...
On 20.01.11 14:06, "Sahoo" <sa...@oracle.com> wrote:
>Hi,
>
>We solved 1 issue in this release:
>
>** Bug
> * [FELIX-2791] - NPE in getStartLevel due to race condition
>
>Staging repository:
>https://repository.apache.org/content/repositories/orgapachefelix-057/
>
>You can use this UNIX script to download the release and verify the
>signatures:
>http://svn.apache.org/repos/asf/felix/trunk/check_staged_release.sh
>
>Usage:
>sh check_staged_release.sh 057 /tmp/felix-staging
>
>Please vote to approve this release:
>
>[ ] +1 Approve the release
>[ ] -1 Veto the release (please provide specific comments)
>
>This vote will be open for 72 hours.
>
>Thanks,
>Sahoo