[jira] [Commented] (KAFKA-263) Enhance single host broker failure test to have 2 topics with uneven distribution on the source brokers

["Neha Narkhede (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13201466#comment-13201466 ] 

Neha Narkhede commented on KAFKA-263:
-------------------------------------

I took a quick look at the patch and have one suggestion -

-    def init(props: Properties) {}
+    def init(props: Properties, tp: String) {}

The above change seems unnecessary. Since the MessageFormatter takes in a Properties object, you can pass in the topic as part of the  --property topic=foo argument for the ConsoleConsumer.

Apart of the above, the patch looks good.
                
> Enhance single host broker failure test to have 2 topics with uneven distribution on the source brokers
> -------------------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-263
>                 URL: https://issues.apache.org/jira/browse/KAFKA-263
>             Project: Kafka
>          Issue Type: Improvement
>          Components: clients
>            Reporter: John Fung
>            Assignee: John Fung
>         Attachments: kafka-263-v1.patch
>
>
> The change is going to have 1 broker in the source cluster to consume messages of only 1 topic as shown below:
> source clusters
> ============
> broker1 - topic1, topic2
> broker2 - topic1, topic2
> broker3 - topic1, topic2
> broker4 - topic1

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira