[GitHub] [daffodil-vscode] stevedlawrence commented on pull request #611: Update LICENSE, NONOTICE, and NOTICE files.

["stevedlawrence (via GitHub)" <gi...@apache.org>]

stevedlawrence commented on PR #611:
URL: https://github.com/apache/daffodil-vscode/pull/611#issuecomment-1533086712

   Thanks for doing this, I know how much of a pain it can be. Found a handful of minor things when looking through the changes:
   
   **fsevents@2.3.2** - listed as a production dependency, but not listed in LICENSE, NONOTICE, or NOTICE
   
   **long@4.0.0** - listed in NONOTICE, but is MIT so should be in LICENSE
   
   **yargs@16.2.0** - listed as a production dependency, but not listed in LICENSE, NONOTICE, or NOTICE
   
   **org.typelevel.simulacrum-scalafix-annotations** - listed in LICENSE, but jar is not in the .vsix file
   
   **com.github.jnr.jnr-x86asm** - listed in LICENSE and NONOTICE, but it is MIT so should not be in NONOTICE
   
   **com.google.code.gson.gson-2.9.0.jar** - listed in NONOTICE only for daffodil-debugger but not omega-edit
   
   **com.monovore.decline_2.13-2.4.1.jar** - listed in NONOTICE only for daffodil-debugger but not omega-edit
   
   **com.typesafe.config-1.4.2.jar** - listed in NONOTICE only for daffodil-debugger but not omega-edit
   
   **org.slf4j.slf4j-api-2.0.4.jar** - listed in LICENSE only for daffodil-debugger but not omega-edit
   
   **io.grpc.grpc-protobuf-1.48.1.jar** - not listed in LICENSE, NONOTICE, or NOTICE
   
   **io.grpc.grpc-protobuf-lite-1.48.1.jar** - not listed in LICENSE, NONOTICE, or NOTICE
   
   Note that I don't mind if we only list things once if they are in both daffodil-debugger and omega-edit, but we should be consistent. In some places we list it twice and mention both daffodil-debugger and omega-edit, some places we only list it for daffodil-debugger.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org