[GitHub] [superset] rusackas commented on a change in pull request #14130: chore: Moves Modal to the components folder

[GitBox <gi...@apache.org>]

rusackas commented on a change in pull request #14130:
URL: https://github.com/apache/superset/pull/14130#discussion_r614576222



##########
File path: superset-frontend/src/components/ImportModal/index.tsx
##########
@@ -20,7 +20,7 @@ import React, { FunctionComponent, useEffect, useRef, useState } from 'react';
 import { styled, t } from '@superset-ui/core';
 
 import Icon from 'src//components/Icon';
-import StyledModal from 'src/common/components/Modal';
+import StyledModal from 'src/components/Modal';

Review comment:
       Not in love with this name (it's inconsistent with the other implementations) which is why I'm not really into default exports, personally. Not a concern for this PR, just whining :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org