You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Zhankun Tang (JIRA)" <ji...@apache.org> on 2016/07/06 02:44:11 UTC
[jira] [Commented] (YARN-3854) Add localization support for docker
images
[ https://issues.apache.org/jira/browse/YARN-3854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15363663#comment-15363663 ]
Zhankun Tang commented on YARN-3854:
------------------------------------
[~sidharta-s], [~templedf], [~hex108], [~zyluo], I have implemented a draft patch for your review. Current results of "test-patch":
| Vote | Subsystem | Runtime | Comment
============================================================================
| 0 | findbugs | 0m 0s | Findbugs executables are not available.
| +1 | @author | 0m 0s | The patch does not contain any @author
| | | | tags.
| +1 | test4tests | 0m 0s | The patch appears to include 2 new or
| | | | modified test files.
| +1 | mvninstall | 3m 20s | branch-2.8 passed
| +1 | compile | 0m 15s | branch-2.8 passed
| +1 | checkstyle | 0m 10s | branch-2.8 passed
| +1 | mvnsite | 0m 15s | branch-2.8 passed
| +1 | mvneclipse | 0m 7s | branch-2.8 passed
| +1 | javadoc | 0m 9s | branch-2.8 passed
| +1 | mvninstall | 0m 12s | the patch passed
| +1 | compile | 0m 14s | the patch passed
| +1 | javac | 0m 14s | the patch passed
| -1 | checkstyle | 0m 9s |
| | | | hadoop-yarn-project/hadoop-yarn/hadoop-yar
| | | | n-server/hadoop-yarn-server-nodemanager:
| | | | The patch generated 1 new + 175 unchanged
| | | | - 1 fixed = 176 total (was 176)
| +1 | mvnsite | 0m 14s | the patch passed
| +1 | mvneclipse | 0m 5s | the patch passed
| +1 | whitespace | 0m 0s | The patch has no whitespace issues.
| +1 | javadoc | 0m 9s | the patch passed
| -1 | unit | 9m 3s | hadoop-yarn-server-nodemanager in the
| | | | patch failed.
| +1 | asflicense | 0m 8s | The patch does not generate ASF License
| | | | warnings.
| | | 14m 51s |
Reason | Tests
Failed junit tests | hadoop.yarn.server.nodemanager.TestLocalDirsHandlerService
| hadoop.yarn.server.nodemanager.TestDirectoryCollection
| hadoop.yarn.server.nodemanager.TestNodeStatusUpdater
| hadoop.yarn.server.nodemanager.containermanager.TestNMProxy
For the checkstyle -1:
Because the "call()" method in ContainerLaunch.java has legacy style issue that exceed the method length (209, max allowed 150), any lines added in this method will cause this "-1". I think we should refactor this "call" method or just change the max allowed length.
For the test case failures:
The three failed test cases exists even in my original hadoop branch 2.8. I don't know the reason now but I guess it has no business with my patch.
Hope for your advice.
> Add localization support for docker images
> ------------------------------------------
>
> Key: YARN-3854
> URL: https://issues.apache.org/jira/browse/YARN-3854
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: yarn
> Reporter: Sidharta Seethana
> Assignee: Zhankun Tang
> Attachments: YARN-3854-branch-2.8.001.patch, YARN-3854_Localization_support_for_Docker_image_v1.pdf, YARN-3854_Localization_support_for_Docker_image_v2.pdf
>
>
> We need the ability to localize images from HDFS and load them for use when launching docker containers.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org