[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #6708: `derive(Debug)` for `Expr`

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #6708:
URL: https://github.com/apache/arrow-datafusion/pull/6708#discussion_r1237398078


##########
datafusion/expr/src/expr.rs:
##########
@@ -869,53 +869,56 @@ impl Expr {
     }
 }
 
-/// Format expressions for display as part of a logical plan. In many cases, this will produce
-/// similar output to `Expr.name()` except that column names will be prefixed with '#'.
-impl fmt::Display for Expr {
-    fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {
-        write!(f, "{self:?}")
-    }
+#[macro_export]

Review Comment:
   I tried https://github.com/apache/arrow-datafusion/pull/6739 -- it isn't great -- any thoughts appreciated



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org