You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <bb...@apache.org> on 2017/11/21 21:09:05 UTC
Review Request 63999: Added env var to set default flags for parallel
test runner.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63999/
-----------------------------------------------------------
Review request for mesos and Alexander Rukletsov.
Repository: mesos
Description
-------
This patch modifies the parallel test runner to examine the
environment variable 'MESOS_GTEST_RUNNER_FLAGS' for a default set of
flags to pass. Flags given explicitly on the command line always have
precedence over default flags from the environment variable.
This allows e.g., to set the default level of parallelism to not
overload systems with many CPUs during 'make check' (which could
ultimately lead to tests hitting timeouts).
Diffs
-----
support/mesos-gtest-runner.py 408e661f4fc9d0060c0eb7a45f1dfd1396f4f6c6
Diff: https://reviews.apache.org/r/63999/diff/1/
Testing
-------
Verified manually that
$ MESOS_GTEST_RUNNER_FLAGS=-j20 ../support/mesos-gtest-runner.py ./3rdparty/stout/tests/stout-tests
executes 20 concurrent runs and that
$ MESOS_GTEST_RUNNER_FLAGS=-j20 ../support/mesos-gtest-runner.py -j6 ./3rdparty/stout/tests/stout-tests
executes 6 concurrent runs and that
Thanks,
Benjamin Bannier
Re: Review Request 63999: Added env var to set default flags for
parallel test runner.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63999/#review191893
-----------------------------------------------------------
support/mesos-gtest-runner.py
Lines 136 (patched)
<https://reviews.apache.org/r/63999/#comment269831>
Could you please add a comment explaining how does the flags passed on the command line have precedence over the defaults?
- Armand Grillet
On Nov. 21, 2017, 9:09 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63999/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2017, 9:09 p.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch modifies the parallel test runner to examine the
> environment variable 'MESOS_GTEST_RUNNER_FLAGS' for a default set of
> flags to pass. Flags given explicitly on the command line always have
> precedence over default flags from the environment variable.
>
> This allows e.g., to set the default level of parallelism to not
> overload systems with many CPUs during 'make check' (which could
> ultimately lead to tests hitting timeouts).
>
>
> Diffs
> -----
>
> support/mesos-gtest-runner.py 408e661f4fc9d0060c0eb7a45f1dfd1396f4f6c6
>
>
> Diff: https://reviews.apache.org/r/63999/diff/1/
>
>
> Testing
> -------
>
> Verified manually that
>
> $ MESOS_GTEST_RUNNER_FLAGS=-j20 ../support/mesos-gtest-runner.py ./3rdparty/stout/tests/stout-tests
>
> executes 20 concurrent runs and that
>
> $ MESOS_GTEST_RUNNER_FLAGS=-j20 ../support/mesos-gtest-runner.py -j6 ./3rdparty/stout/tests/stout-tests
>
> executes 6 concurrent runs and that
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 63999: Added env var to set default flags for
parallel test runner.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63999/#review191898
-----------------------------------------------------------
Ship it!
Ship It!
- Armand Grillet
On nov. 27, 2017, 3:44 après-midi, Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63999/
> -----------------------------------------------------------
>
> (Updated nov. 27, 2017, 3:44 après-midi)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch modifies the parallel test runner to examine the
> environment variable 'MESOS_GTEST_RUNNER_FLAGS' for a default set of
> flags to pass. Flags given explicitly on the command line always have
> precedence over default flags from the environment variable.
>
> This allows e.g., to set the default level of parallelism to not
> overload systems with many CPUs during 'make check' (which could
> ultimately lead to tests hitting timeouts).
>
>
> Diffs
> -----
>
> support/mesos-gtest-runner.py 408e661f4fc9d0060c0eb7a45f1dfd1396f4f6c6
>
>
> Diff: https://reviews.apache.org/r/63999/diff/2/
>
>
> Testing
> -------
>
> Verified manually that
>
> $ MESOS_GTEST_RUNNER_FLAGS=-j20 ../support/mesos-gtest-runner.py ./3rdparty/stout/tests/stout-tests
>
> executes 20 concurrent runs and that
>
> $ MESOS_GTEST_RUNNER_FLAGS=-j20 ../support/mesos-gtest-runner.py -j6 ./3rdparty/stout/tests/stout-tests
>
> executes 6 concurrent runs and that
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 63999: Added env var to set default flags for
parallel test runner.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63999/
-----------------------------------------------------------
(Updated Nov. 27, 2017, 4:44 p.m.)
Review request for mesos and Alexander Rukletsov.
Changes
-------
Added some explanation of implementation details to comment.
Repository: mesos
Description
-------
This patch modifies the parallel test runner to examine the
environment variable 'MESOS_GTEST_RUNNER_FLAGS' for a default set of
flags to pass. Flags given explicitly on the command line always have
precedence over default flags from the environment variable.
This allows e.g., to set the default level of parallelism to not
overload systems with many CPUs during 'make check' (which could
ultimately lead to tests hitting timeouts).
Diffs (updated)
-----
support/mesos-gtest-runner.py 408e661f4fc9d0060c0eb7a45f1dfd1396f4f6c6
Diff: https://reviews.apache.org/r/63999/diff/2/
Changes: https://reviews.apache.org/r/63999/diff/1-2/
Testing
-------
Verified manually that
$ MESOS_GTEST_RUNNER_FLAGS=-j20 ../support/mesos-gtest-runner.py ./3rdparty/stout/tests/stout-tests
executes 20 concurrent runs and that
$ MESOS_GTEST_RUNNER_FLAGS=-j20 ../support/mesos-gtest-runner.py -j6 ./3rdparty/stout/tests/stout-tests
executes 6 concurrent runs and that
Thanks,
Benjamin Bannier