You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@celix.apache.org by Pepijn Noltes <pe...@gmail.com> on 2012/12/03 19:23:24 UTC
remote shell
Hi All,
I'm almost finish with a remote shell implementation for Apache Celix. The
remote shell enables telnet clients to connect to a Apache Celix shell.
Is it alright that I commit this directly to SVN or should I first send a
patch for review?
Greetings,
Pepijn
Re: remote shell
Posted by Pepijn Noltes <pe...@gmail.com>.
On Mon, Dec 3, 2012 at 9:11 PM, Alexander Broekhuis
<a....@gmail.com>wrote:
> Hi,
>
> I'm almost finish with a remote shell implementation for Apache Celix. The
> > remote shell enables telnet clients to connect to a Apache Celix shell.
> >
>
> Nice. I assume it uses the Shell bundle as backend?
>
Yes it does, the only dependency is to the shell service.
>
>
> >
> > Is it alright that I commit this directly to SVN or should I first send a
> > patch for review?
> >
>
> Since it hasn't been developed on trunk I think it is better to use a code
> donation for this.
> Celix mentors: What do you guys think?
>
> Anything else which is developed on trunk can either use a commit first
> review later model, or use the mailing list for discusion. For new
> stuff/big impact changes I prefer the latter. Some more technical
> discussion on the list/Jira is a good thing IMHO.
>
>
> --
> Met vriendelijke groet,
>
> Alexander Broekhuis
>
Re: remote shell
Posted by Pepijn Noltes <pe...@gmail.com>.
On Tue, Dec 4, 2012 at 10:15 AM, Karl Pauls <ka...@gmail.com> wrote:
> On Tue, Dec 4, 2012 at 9:28 AM, Pepijn Noltes <pepijnnoltes@gmail.com
> >wrote:
>
> > On Mon, Dec 3, 2012 at 9:37 PM, Alexander Broekhuis
> > <a....@gmail.com>wrote:
> >
> > > >
> > > > Depends. If he is a commiter and was the only one working on it with
> > the
> > > > sole purpose to commit it to trunk when done you don't need a
> donation.
> > > The
> > > > icla (and ccla, respectively) are enough in that case.
> > > >
> > >
> > > Good point, I automatically assumed the work has been done for Thales..
> > >
> >
> > This work has been done in Thales time, but only by me and with the sole
> > purpose to commit it to trunk. I was under the impression that indeed the
> > icla and ccla will cover this. Just to be clear, this is still the case
> if
> > the work was done in Thales time?
>
>
> Yes, assuming you have an icla and a ccla from Thales covering you on file
> as well. At that point, we trust that you make sure you only contribute
> what you are allowed to contribute (i.e., make sure Thales knows about it
> and you get whatever internal sign off you need).
>
> regards,
>
> Karl
>
>
Thanks for the clarification Karl.
I committed the remote shell code under issue [1]. Any comments on the
implementation are welcome.
[1] https://issues.apache.org/jira/browse/CELIX-44
Greetings,
Pepijn
Re: remote shell
Posted by Karl Pauls <ka...@gmail.com>.
On Tue, Dec 4, 2012 at 9:28 AM, Pepijn Noltes <pe...@gmail.com>wrote:
> On Mon, Dec 3, 2012 at 9:37 PM, Alexander Broekhuis
> <a....@gmail.com>wrote:
>
> > >
> > > Depends. If he is a commiter and was the only one working on it with
> the
> > > sole purpose to commit it to trunk when done you don't need a donation.
> > The
> > > icla (and ccla, respectively) are enough in that case.
> > >
> >
> > Good point, I automatically assumed the work has been done for Thales..
> >
>
> This work has been done in Thales time, but only by me and with the sole
> purpose to commit it to trunk. I was under the impression that indeed the
> icla and ccla will cover this. Just to be clear, this is still the case if
> the work was done in Thales time?
Yes, assuming you have an icla and a ccla from Thales covering you on file
as well. At that point, we trust that you make sure you only contribute
what you are allowed to contribute (i.e., make sure Thales knows about it
and you get whatever internal sign off you need).
regards,
Karl
>
> >
> > --
> > Met vriendelijke groet,
> >
> > Alexander Broekhuis
> >
>
--
Karl Pauls
karlpauls@gmail.com
http://twitter.com/karlpauls
http://www.linkedin.com/in/karlpauls
https://profiles.google.com/karlpauls
Re: remote shell
Posted by Pepijn Noltes <pe...@gmail.com>.
On Mon, Dec 3, 2012 at 9:37 PM, Alexander Broekhuis
<a....@gmail.com>wrote:
> >
> > Depends. If he is a commiter and was the only one working on it with the
> > sole purpose to commit it to trunk when done you don't need a donation.
> The
> > icla (and ccla, respectively) are enough in that case.
> >
>
> Good point, I automatically assumed the work has been done for Thales..
>
This work has been done in Thales time, but only by me and with the sole
purpose to commit it to trunk. I was under the impression that indeed the
icla and ccla will cover this. Just to be clear, this is still the case if
the work was done in Thales time?
>
>
> --
> Met vriendelijke groet,
>
> Alexander Broekhuis
>
Re: remote shell
Posted by Karl Pauls <ka...@gmail.com>.
i just notice that the webside and the incubator status file should be
updated with a proper commiter list. I couldn't figure out using any of
them whether he is a commiter or no. He is, i know but you should add a
"who we are" and get the incubator status page up to date.
regards,
Karl
On Mon, Dec 3, 2012 at 9:37 PM, Alexander Broekhuis
<a....@gmail.com>wrote:
> >
> > Depends. If he is a commiter and was the only one working on it with the
> > sole purpose to commit it to trunk when done you don't need a donation.
> The
> > icla (and ccla, respectively) are enough in that case.
> >
>
> Good point, I automatically assumed the work has been done for Thales..
>
>
> --
> Met vriendelijke groet,
>
> Alexander Broekhuis
>
--
Karl Pauls
karlpauls@gmail.com
http://twitter.com/karlpauls
http://www.linkedin.com/in/karlpauls
https://profiles.google.com/karlpauls
Re: remote shell
Posted by Alexander Broekhuis <a....@gmail.com>.
>
> Depends. If he is a commiter and was the only one working on it with the
> sole purpose to commit it to trunk when done you don't need a donation. The
> icla (and ccla, respectively) are enough in that case.
>
Good point, I automatically assumed the work has been done for Thales..
--
Met vriendelijke groet,
Alexander Broekhuis
Re: remote shell
Posted by Karl Pauls <ka...@gmail.com>.
On Mon, Dec 3, 2012 at 9:11 PM, Alexander Broekhuis
<a....@gmail.com>wrote:
> Hi,
>
> I'm almost finish with a remote shell implementation for Apache Celix. The
> > remote shell enables telnet clients to connect to a Apache Celix shell.
> >
>
> Nice. I assume it uses the Shell bundle as backend?
>
>
> >
> > Is it alright that I commit this directly to SVN or should I first send a
> > patch for review?
> >
>
> Since it hasn't been developed on trunk I think it is better to use a code
> donation for this.
> Celix mentors: What do you guys think?
>
Depends. If he is a commiter and was the only one working on it with the
sole purpose to commit it to trunk when done you don't need a donation. The
icla (and ccla, respectively) are enough in that case.
regards,
Karl
> Anything else which is developed on trunk can either use a commit first
> review later model, or use the mailing list for discusion. For new
> stuff/big impact changes I prefer the latter. Some more technical
> discussion on the list/Jira is a good thing IMHO.
>
>
> --
> Met vriendelijke groet,
>
> Alexander Broekhuis
>
--
Karl Pauls
karlpauls@gmail.com
http://twitter.com/karlpauls
http://www.linkedin.com/in/karlpauls
https://profiles.google.com/karlpauls
Re: remote shell
Posted by Alexander Broekhuis <a....@gmail.com>.
Hi,
I'm almost finish with a remote shell implementation for Apache Celix. The
> remote shell enables telnet clients to connect to a Apache Celix shell.
>
Nice. I assume it uses the Shell bundle as backend?
>
> Is it alright that I commit this directly to SVN or should I first send a
> patch for review?
>
Since it hasn't been developed on trunk I think it is better to use a code
donation for this.
Celix mentors: What do you guys think?
Anything else which is developed on trunk can either use a commit first
review later model, or use the mailing list for discusion. For new
stuff/big impact changes I prefer the latter. Some more technical
discussion on the list/Jira is a good thing IMHO.
--
Met vriendelijke groet,
Alexander Broekhuis