[jira] [Comment Edited] (PHOENIX-4755) Provide an option to plugin custom avatica server config in PQS

["Josh Elser (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-4755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16582994#comment-16582994 ] 

Josh Elser edited comment on PHOENIX-4755 at 8/16/18 7:50 PM:
--------------------------------------------------------------

A few nits on formatting that would be nice to fix:
{code:java}
+    if (null != httpKeytabPath) httpKeytab = new File(httpKeytabPath);
{code}
Use braces for if-statement.
{code:java}
+    if ((null != httpKeytabPath) && (null != httpPrincipal)) {
{code}
Remove unnecessary inner-parens.

I may be missing something, but I feel like 003 doesn't give the ability for me to specify a implementation of AvaticaServerConfigurationFactory via the configuration. Also, does 003 actually apply against master as-is?

I'm now worrying that was also missing from [~alexaraujo]'s patch too for ServerCustomizersFactory. There's the InstanceResolver call that would do this, but that depends on custom code to launch PQS (which is unnecessarily pedantic).


was (Author: elserj):
A few nits on formatting that would be nice to fix:
{code:java}
+    if (null != httpKeytabPath) httpKeytab = new File(httpKeytabPath);
{code}
Use braces for if-statement.
{code:java}
+    if ((null != httpKeytabPath) && (null != httpPrincipal)) {
{code}
Remove unnecessary inner-parens.

I may be missing something, but I feel like 003 doesn't give the ability for me to specify a implementation of AvaticaServerConfigurationFactory via the configuration.

I'm now worrying that was also missing from [~alexaraujo]'s patch too for ServerCustomizersFactory. There's the InstanceResolver call that would do this, but that depends on custom code to launch PQS (which is unnecessarily pedantic).

> Provide an option to plugin custom avatica server config in PQS
> ---------------------------------------------------------------
>
>                 Key: PHOENIX-4755
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4755
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Karan Mehta
>            Priority: Major
>         Attachments: PHOENIX-4755.001.diff, PHOENIX-4755.002.diff, PHOENIX-4755.003.diff
>
>
> CALCITE-2294 Allow customization for {{AvaticaServerConfiguration}} for plugging new authentication mechanisms
> Add a new Phoenix level property and provide resolve the class using {{InstanceResolver}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)