You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/04/25 15:02:43 UTC

[GitHub] [airflow] Dewsmen opened a new issue #8557: Count SKIPPED as SUCCESS if wait_for_downstream=True

Dewsmen opened a new issue #8557:
URL: https://github.com/apache/airflow/issues/8557


   If previous SUCCESS run has tasks with state SUCCESS and SKIPPED then task with wait_for_downstream=True will stop with "The tasks downstream of the previous task instance haven't completed." message.
   
   Bug is in the 'are_dependents_done' function in task instance model (https://github.com/apache/airflow/blob/master/airflow/models/taskinstance.py) just SUCCESS tasks counts:
   ```
           ti = session.query(func.count(TaskInstance.task_id)).filter(
               TaskInstance.dag_id == self.dag_id,
               TaskInstance.task_id.in_(task.downstream_task_ids),
               TaskInstance.execution_date == self.execution_date,
               TaskInstance.state == State.SUCCESS,
           )
           count = ti[0][0]
           return count == len(task.downstream_task_ids)
   ``` 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] Dewsmen closed issue #8557: Count SKIPPED as SUCCESS if wait_for_downstream=True

Posted by GitBox <gi...@apache.org>.
Dewsmen closed issue #8557:
URL: https://github.com/apache/airflow/issues/8557


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on issue #8557: Count SKIPPED as SUCCESS if wait_for_downstream=True

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #8557:
URL: https://github.com/apache/airflow/issues/8557#issuecomment-619392460


   Thanks for opening your first issue here! Be sure to follow the issue template!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] Dewsmen commented on issue #8557: Count SKIPPED as SUCCESS if wait_for_downstream=True

Posted by GitBox <gi...@apache.org>.
Dewsmen commented on issue #8557:
URL: https://github.com/apache/airflow/issues/8557#issuecomment-652951751


   The issue was fixed and merged with [PR](https://github.com/apache/airflow/pull/7735)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org