[impala] branch master updated: IMPALA-11195: (Addendum) use actual SSL context

[mi...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

michaelsmith pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git


The following commit(s) were added to refs/heads/master by this push:
     new 4a5057d27 IMPALA-11195: (Addendum) use actual SSL context
4a5057d27 is described below

commit 4a5057d2714b8030676bae3a2da73fd844df7b58
Author: Michael Smith <mi...@cloudera.com>
AuthorDate: Wed Aug 16 13:23:21 2023 -0700

    IMPALA-11195: (Addendum) use actual SSL context
    
    Uses the SSL context rather than sq_context for
    SSL_CTX_set_info_callback. The prior code compiled successfully with a
    warning I missed, and caused webserver-test to fail SslTest.
    
    Change-Id: I7325ecc78b481354a46d77659edbd876593d934b
    Reviewed-on: http://gerrit.cloudera.org:8080/20373
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
    Reviewed-by: Michael Smith <mi...@cloudera.com>
---
 be/src/thirdparty/squeasel/squeasel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/be/src/thirdparty/squeasel/squeasel.c b/be/src/thirdparty/squeasel/squeasel.c
index dc6fab912..784042f89 100644
--- a/be/src/thirdparty/squeasel/squeasel.c
+++ b/be/src/thirdparty/squeasel/squeasel.c
@@ -3939,7 +3939,7 @@ static int set_ssl_option(struct sq_context *ctx) {
   // possible to use the undocumented SSL3_FLAGS_NO_RENEGOTIATE_CIPHERS flag.
   // We need to set the flag in the callback 'ssl_disable_renegotiation_cb' after
   // handshake is done, otherwise the flag would get reset in SSL_accept().
-  SSL_CTX_set_info_callback(ctx, ssl_disable_renegotiation_cb);
+  SSL_CTX_set_info_callback(ctx->ssl_ctx, ssl_disable_renegotiation_cb);
 #else
   static_error(false, "Found SSL version that is vulnerable to CVE-2009-3555.");
 #endif