[GitHub] [ignite] ptupitsyn commented on a change in pull request #8580: IGNITE-13865 Support DateTime as a key or value in .NET and Java

[GitBox <gi...@apache.org>]

ptupitsyn commented on a change in pull request #8580:
URL: https://github.com/apache/ignite/pull/8580#discussion_r544913793



##########
File path: modules/platforms/dotnet/Apache.Ignite.Core/Impl/Binary/Marshaller.cs
##########
@@ -950,5 +950,13 @@ private static IBinaryNameMapper GetDefaultNameMapper()
         {
             return BinaryBasicNameMapper.FullNameInstance;
         }
+
+        /// <summary>
+        /// Gets force timestamp flag value.
+        /// </summary>
+        public bool ForceTimestamp()

Review comment:
       Let's convert this method to a property

##########
File path: modules/platforms/dotnet/Apache.Ignite.Core/Binary/BinaryReflectiveSerializer.cs
##########
@@ -46,6 +46,7 @@ public sealed class BinaryReflectiveSerializer : IBinarySerializer
         private bool _isInUse;
 
         /** Force timestamp flag. */
+        [Obsolete("Deprecated, use BinaryConfiguration.ForceTimestamp instead.")]

Review comment:
       I don't think this deprecation is necessary. This flag is still useful.
   
   PS `[Obsolete]` should be applied to a public property, not a private field
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org