[GitHub] [hbase] petersomogyi commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL

[GitBox <gi...@apache.org>]

petersomogyi commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL
URL: https://github.com/apache/hbase/pull/371#discussion_r303304479
 
 

 ##########
 File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
 ##########
 @@ -1445,6 +1445,9 @@
       "hbase.util.default.lossycounting.errorrate";
   public static final String NOT_IMPLEMENTED = "Not implemented";
 
+  // Default Snapshot TTL - 30 days (good enough?)
+  public static final long DEFAULT_SNAPSHOT_TTL = 24 * 3600 * 30;
 
 Review comment:
   I agree with @Reidddddd that we should keep the old behavior and keep snapshots forever when TTL is not specified.
   
   In case a user wants to have a new snapshot with TTL but have existing snapshots from a previous installation they will enable this feature and the old snapshots going to be deleted in 30 days. This shouldn't be the case.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services