You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Gaurav Nagar <gn...@hortonworks.com> on 2015/12/28 13:08:14 UTC
Review Request 41739: Hive views does not honour auth_to_local rules
when running queries
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41739/
-----------------------------------------------------------
Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
Bugs: AMBARI-14503
https://issues.apache.org/jira/browse/AMBARI-14503
Repository: ambari
Description
-------
Changed getUsername call to return name with auth_to_local conversion in ViewContextImpl.
Added getLoggedinUser to return loggedin ambari user.
Diffs
-----
ambari-server/pom.xml b5a9d49
ambari-server/src/main/java/org/apache/ambari/server/view/ViewContextImpl.java a22c514
ambari-views/src/main/java/org/apache/ambari/view/ViewContext.java c0cae80
contrib/views/files/src/main/resources/view.xml 58a7682
contrib/views/hive/src/main/resources/view.xml e04ed4b
contrib/views/pig/src/main/resources/view.xml 30efae8
contrib/views/tez/src/main/resources/view.xml d1ad5ad
Diff: https://reviews.apache.org/r/41739/diff/
Testing
-------
Manual Testing.
Thanks,
Gaurav Nagar
Re: Review Request 41739: Hive views does not honour auth_to_local
rules when running queries
Posted by Gaurav Nagar <gn...@hortonworks.com>.
> On Dec. 28, 2015, 3:52 p.m., Apache Ambari wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/view/ViewContextImpl.java, line 240
> > <https://reviews.apache.org/r/41739/diff/1/?file=1176660#file1176660line240>
> >
> > Should the view have precedence over the cluster's rule?
If view instance is created in attached mode, then cluster rules are used.For custom configuration,value of authToLocal field is used as rules.
> On Dec. 28, 2015, 3:52 p.m., Apache Ambari wrote:
> > ambari-server/pom.xml, line 49
> > <https://reviews.apache.org/r/41739/diff/1/?file=1176659#file1176659line49>
> >
> > Why was this needed?
We are using hadoop-auth dependency for converting names.
- Gaurav
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41739/#review111991
-----------------------------------------------------------
On Dec. 28, 2015, 12:08 p.m., Gaurav Nagar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41739/
> -----------------------------------------------------------
>
> (Updated Dec. 28, 2015, 12:08 p.m.)
>
>
> Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
>
>
> Bugs: AMBARI-14503
> https://issues.apache.org/jira/browse/AMBARI-14503
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Changed getUsername call to return name with auth_to_local conversion in ViewContextImpl.
> Added getLoggedinUser to return loggedin ambari user.
>
>
> Diffs
> -----
>
> ambari-server/pom.xml b5a9d49
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewContextImpl.java a22c514
> ambari-views/src/main/java/org/apache/ambari/view/ViewContext.java c0cae80
> contrib/views/files/src/main/resources/view.xml 58a7682
> contrib/views/hive/src/main/resources/view.xml e04ed4b
> contrib/views/pig/src/main/resources/view.xml 30efae8
> contrib/views/tez/src/main/resources/view.xml d1ad5ad
>
> Diff: https://reviews.apache.org/r/41739/diff/
>
>
> Testing
> -------
>
> Manual Testing.
>
>
> Thanks,
>
> Gaurav Nagar
>
>
Re: Review Request 41739: Hive views does not honour auth_to_local
rules when running queries
Posted by Alejandro Fernandez <af...@hortonworks.com>.
> On Dec. 28, 2015, 3:52 p.m., Apache Ambari wrote:
> >
I created a service account for "Apache Ambari" and forgot to logout and re-login with my personal account.
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41739/#review111991
-----------------------------------------------------------
On Dec. 28, 2015, 12:08 p.m., Gaurav Nagar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41739/
> -----------------------------------------------------------
>
> (Updated Dec. 28, 2015, 12:08 p.m.)
>
>
> Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
>
>
> Bugs: AMBARI-14503
> https://issues.apache.org/jira/browse/AMBARI-14503
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Changed getUsername call to return name with auth_to_local conversion in ViewContextImpl.
> Added getLoggedinUser to return loggedin ambari user.
>
>
> Diffs
> -----
>
> ambari-server/pom.xml b5a9d49
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewContextImpl.java a22c514
> ambari-views/src/main/java/org/apache/ambari/view/ViewContext.java c0cae80
> contrib/views/files/src/main/resources/view.xml 58a7682
> contrib/views/hive/src/main/resources/view.xml e04ed4b
> contrib/views/pig/src/main/resources/view.xml 30efae8
> contrib/views/tez/src/main/resources/view.xml d1ad5ad
>
> Diff: https://reviews.apache.org/r/41739/diff/
>
>
> Testing
> -------
>
> Manual Testing.
>
>
> Thanks,
>
> Gaurav Nagar
>
>
Re: Review Request 41739: Hive views does not honour auth_to_local
rules when running queries
Posted by Apache Ambari <ap...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41739/#review111991
-----------------------------------------------------------
ambari-server/pom.xml (line 49)
<https://reviews.apache.org/r/41739/#comment172304>
Why was this needed?
ambari-server/src/main/java/org/apache/ambari/server/view/ViewContextImpl.java (line 240)
<https://reviews.apache.org/r/41739/#comment172303>
Should the view have precedence over the cluster's rule?
- Apache Ambari
On Dec. 28, 2015, 12:08 p.m., Gaurav Nagar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41739/
> -----------------------------------------------------------
>
> (Updated Dec. 28, 2015, 12:08 p.m.)
>
>
> Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
>
>
> Bugs: AMBARI-14503
> https://issues.apache.org/jira/browse/AMBARI-14503
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Changed getUsername call to return name with auth_to_local conversion in ViewContextImpl.
> Added getLoggedinUser to return loggedin ambari user.
>
>
> Diffs
> -----
>
> ambari-server/pom.xml b5a9d49
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewContextImpl.java a22c514
> ambari-views/src/main/java/org/apache/ambari/view/ViewContext.java c0cae80
> contrib/views/files/src/main/resources/view.xml 58a7682
> contrib/views/hive/src/main/resources/view.xml e04ed4b
> contrib/views/pig/src/main/resources/view.xml 30efae8
> contrib/views/tez/src/main/resources/view.xml d1ad5ad
>
> Diff: https://reviews.apache.org/r/41739/diff/
>
>
> Testing
> -------
>
> Manual Testing.
>
>
> Thanks,
>
> Gaurav Nagar
>
>
Re: Review Request 41739: Hive views does not honour auth_to_local
rules when running queries
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41739/#review112128
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Dec. 28, 2015, 12:08 p.m., Gaurav Nagar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41739/
> -----------------------------------------------------------
>
> (Updated Dec. 28, 2015, 12:08 p.m.)
>
>
> Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
>
>
> Bugs: AMBARI-14503
> https://issues.apache.org/jira/browse/AMBARI-14503
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Changed getUsername call to return name with auth_to_local conversion in ViewContextImpl.
> Added getLoggedinUser to return loggedin ambari user.
>
>
> Diffs
> -----
>
> ambari-server/pom.xml b5a9d49
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewContextImpl.java a22c514
> ambari-views/src/main/java/org/apache/ambari/view/ViewContext.java c0cae80
> contrib/views/files/src/main/resources/view.xml 58a7682
> contrib/views/hive/src/main/resources/view.xml e04ed4b
> contrib/views/pig/src/main/resources/view.xml 30efae8
> contrib/views/tez/src/main/resources/view.xml d1ad5ad
>
> Diff: https://reviews.apache.org/r/41739/diff/
>
>
> Testing
> -------
>
> Manual Testing.
>
>
> Thanks,
>
> Gaurav Nagar
>
>
Re: Review Request 41739: Hive views does not honour auth_to_local
rules when running queries
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41739/
-----------------------------------------------------------
(Updated Dec. 29, 2015, 7:06 a.m.)
Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
Changes
-------
Added synchronized block when converting name.
Added loggedinUser in template, so that it can be used in instance properties.
Bugs: AMBARI-14503
https://issues.apache.org/jira/browse/AMBARI-14503
Repository: ambari
Description
-------
Changed getUsername call to return name with auth_to_local conversion in ViewContextImpl.
Added getLoggedinUser to return loggedin ambari user.
Diffs (updated)
-----
ambari-server/pom.xml b5a9d49
ambari-server/src/main/java/org/apache/ambari/server/view/ViewContextImpl.java a22c514
ambari-views/src/main/java/org/apache/ambari/view/ViewContext.java c0cae80
contrib/views/files/src/main/resources/view.xml 58a7682
contrib/views/hive/src/main/resources/view.xml e04ed4b
contrib/views/pig/src/main/resources/view.xml 30efae8
contrib/views/tez/src/main/resources/view.xml d1ad5ad
Diff: https://reviews.apache.org/r/41739/diff/
Testing
-------
Manual Testing.
Thanks,
Gaurav Nagar