You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2019/08/01 19:14:26 UTC
Review Request 71229: Fixed the webui roles table resource sorting.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71229/
-----------------------------------------------------------
Review request for mesos, Andrei Sekretenko and Meng Zhu.
Repository: mesos
Description
-------
All of the roles table resource columns were using the wrong
keys for sorting.
Diffs
-----
src/webui/app/roles/roles.html b290587463a6ebc17bf645530247e46d4e3cff2a
Diff: https://reviews.apache.org/r/71229/diff/1/
Testing
-------
manual testing
Thanks,
Benjamin Mahler
Re: Review Request 71229: Fixed the webui roles table resource
sorting.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71229/#review217042
-----------------------------------------------------------
Patch looks great!
Reviews applied: [71229]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Aug. 1, 2019, 12:14 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71229/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2019, 12:14 p.m.)
>
>
> Review request for mesos, Andrei Sekretenko and Meng Zhu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> All of the roles table resource columns were using the wrong
> keys for sorting.
>
>
> Diffs
> -----
>
> src/webui/app/roles/roles.html b290587463a6ebc17bf645530247e46d4e3cff2a
>
>
> Diff: https://reviews.apache.org/r/71229/diff/1/
>
>
> Testing
> -------
>
> manual testing
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 71229: Fixed the webui roles table resource
sorting.
Posted by Vinod Kone <vi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71229/#review217041
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Aug. 1, 2019, 7:14 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71229/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2019, 7:14 p.m.)
>
>
> Review request for mesos, Andrei Sekretenko and Meng Zhu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> All of the roles table resource columns were using the wrong
> keys for sorting.
>
>
> Diffs
> -----
>
> src/webui/app/roles/roles.html b290587463a6ebc17bf645530247e46d4e3cff2a
>
>
> Diff: https://reviews.apache.org/r/71229/diff/1/
>
>
> Testing
> -------
>
> manual testing
>
>
> Thanks,
>
> Benjamin Mahler
>
>