[GitHub] Shihta edited a comment on issue #3281: CIAB: Fixed the method of obtaining IP

[GitBox <gi...@apache.org>]

Shihta edited a comment on issue #3281: CIAB: Fixed the method of obtaining IP
URL: https://github.com/apache/trafficcontrol/pull/3281#issuecomment-463468261
 
 
   @JBevillC thanks for helping me review it!
   
   The 2 problems you found are not caused by this commit.
   As you mentioned that there are some files in `infrastructure/cdn-in-a-box/traffic_ops_data/servers`.
   They will be modified by `infrastructure/cdn-in-a-box/traffic_ops/set-to-ips-from-dns.sh` and then be sent by container enroller.
   
   In fact, I have sent a PR #3264 trying to solve these 2 problems.
   In PR #3264, it add a retry mechanism in obtaining IP and fix the netmask issue.
   I didn't highlight it in slack because I'm not sure it's a right direction.
   
   Should we just fix them by the PR #3264?
   or should we let each service goes to enroll by themselves? like your opinion
   
   It seems like the option 2 is better than 1.
   If we want to select option 2, I'll close PR #3264 first and work the selection 2 in the future.
   
   ------------
   
   Back to this PR
   It aim to fix the sequence of registering DNS record, not service enrollment of TO.
   I don't know why, but registering DNS record of TO sometimes just fails in my environment.
   
   1. The container enroller always shows:
   ```
   + nc -z trafficops.infra.ciab.test 443
   trafficops.infra.ciab.test: forward host lookup failed: Unknown host
   Waiting for https://trafficops.infra.ciab.test:443
   + echo 'Waiting for https://trafficops.infra.ciab.test:443'
   + sleep 5
   ```
   
   as you can see, it shows *forward host lookup failed: Unknown host*
   
   2. After check the container trafficops-perl log, I found:
   ```
   + insert-self-into-dns.sh
   insert-self-into-dns domain ciab.test dns_key_path /shared/dns/Kciab.test.+157+11874.private my_host trafficops my_ip  my_fqdn trafficops.infra.ciab.test cmd 'update add trafficops.infra.ciab.test 86400 A '
   could not read rdata
   syntax error
   ```
   
   as you can see, there is no ip addr
   
   That why I sent this PR

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services