You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/28 07:53:00 UTC
[GitHub] [flink] ShubinRuan opened a new pull request #13817: [HotFix][docs] Fix broken link of docker.md
ShubinRuan opened a new pull request #13817:
URL: https://github.com/apache/flink/pull/13817
## What is the purpose of the change
Fix broken link of docker.md
The page url is https://ci.apache.org/projects/flink/flink-docs-master/ops/deployment/docker.html
The markdown file is located in flink/docs/ops/deployment/docker.md
The "how to run the Flink image" link in the Advanced customization chapter of docker.md cannot be redirected normally。
## Brief change log
- Fix broken link of `flink/docs/ops/deployment/docker.md`
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with @public(Evolving): no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? no
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] ShubinRuan commented on pull request #13817: [HotFix][docs] Fix broken link of docker.md
Posted by GitBox <gi...@apache.org>.
ShubinRuan commented on pull request #13817:
URL: https://github.com/apache/flink/pull/13817#issuecomment-719102494
> Please also change docs/ops/deployment/docker.zh.md accordingly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] ShubinRuan commented on pull request #13817: [HotFix][docs] Fix broken link of docker.md
Posted by GitBox <gi...@apache.org>.
ShubinRuan commented on pull request #13817:
URL: https://github.com/apache/flink/pull/13817#issuecomment-719104164
@zentol I have created a PR(https://github.com/apache/flink/pull/13812) that is in the review process. This PR will translate the "docs/ops/deployment/docker.zh.md" document into Chinese. I will modify the corresponding link to ensure it works properly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13817: [HotFix][docs] Fix broken link of docker.md
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13817:
URL: https://github.com/apache/flink/pull/13817#issuecomment-717771629
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f7fcad2291f072819e6576b291327abd16947445",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8481",
"triggerID" : "f7fcad2291f072819e6576b291327abd16947445",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f7fcad2291f072819e6576b291327abd16947445 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8481)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] ShubinRuan removed a comment on pull request #13817: [HotFix][docs] Fix broken link of docker.md
Posted by GitBox <gi...@apache.org>.
ShubinRuan removed a comment on pull request #13817:
URL: https://github.com/apache/flink/pull/13817#issuecomment-719102494
> Please also change docs/ops/deployment/docker.zh.md accordingly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] ShubinRuan closed pull request #13817: [HotFix][docs] Fix broken link of docker.md
Posted by GitBox <gi...@apache.org>.
ShubinRuan closed pull request #13817:
URL: https://github.com/apache/flink/pull/13817
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13817: [HotFix][docs] Fix broken link of docker.md
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13817:
URL: https://github.com/apache/flink/pull/13817#issuecomment-717771629
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f7fcad2291f072819e6576b291327abd16947445",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8481",
"triggerID" : "f7fcad2291f072819e6576b291327abd16947445",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f7fcad2291f072819e6576b291327abd16947445 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8481)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13817: [HotFix][docs] Fix broken link of docker.md
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13817:
URL: https://github.com/apache/flink/pull/13817#issuecomment-717763924
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit f7fcad2291f072819e6576b291327abd16947445 (Wed Oct 28 07:55:51 UTC 2020)
**Warnings:**
* Documentation files were touched, but no `.zh.md` files: Update Chinese documentation or file Jira ticket.
* **Invalid pull request title: No valid Jira ID provided**
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13817: [HotFix][docs] Fix broken link of docker.md
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13817:
URL: https://github.com/apache/flink/pull/13817#issuecomment-717771629
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f7fcad2291f072819e6576b291327abd16947445",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f7fcad2291f072819e6576b291327abd16947445",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f7fcad2291f072819e6576b291327abd16947445 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org