You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2019/07/30 14:26:40 UTC

[GitHub] [incubator-iotdb] Ring-k commented on a change in pull request #323: implement rpc compression

Ring-k commented on a change in pull request #323: implement rpc compression
URL: https://github.com/apache/incubator-iotdb/pull/323#discussion_r308753586
 
 

 ##########
 File path: jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBConnection.java
 ##########
 @@ -89,7 +90,10 @@ public IoTDBConnection(String url, Properties info) throws SQLException, TTransp
     supportedProtocols.add(TSProtocolVersion.TSFILE_SERVICE_PROTOCOL_V1);
 
     openTransport();
-    client = new TSIService.Client(new TBinaryProtocol(transport));
+    if(Config.rpcThriftCompressionEnable)
+      client = new TSIService.Client(new TCompactProtocol(transport));
+    else
+      client = new TSIService.Client(new TBinaryProtocol(transport));
 
 Review comment:
   Alright, thanks for your suggestion.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services