You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@solr.apache.org by kr...@apache.org on 2022/10/18 15:02:04 UTC
[solr] branch main updated: SOLR-16467: Add check for working locale in PackageManagerCLITest
This is an automated email from the ASF dual-hosted git repository.
krisden pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/solr.git
The following commit(s) were added to refs/heads/main by this push:
new 58617724d48 SOLR-16467: Add check for working locale in PackageManagerCLITest
58617724d48 is described below
commit 58617724d48f23848264fd41ed94cf7af391d345
Author: Kevin Risden <kr...@apache.org>
AuthorDate: Tue Oct 18 10:59:40 2022 -0400
SOLR-16467: Add check for working locale in PackageManagerCLITest
---
.../apache/solr/cloud/PackageManagerCLITest.java | 22 ++++++++++++++++++++--
1 file changed, 20 insertions(+), 2 deletions(-)
diff --git a/solr/core/src/test/org/apache/solr/cloud/PackageManagerCLITest.java b/solr/core/src/test/org/apache/solr/cloud/PackageManagerCLITest.java
index 0403b48060d..665712bf28f 100644
--- a/solr/core/src/test/org/apache/solr/cloud/PackageManagerCLITest.java
+++ b/solr/core/src/test/org/apache/solr/cloud/PackageManagerCLITest.java
@@ -19,11 +19,14 @@ package org.apache.solr.cloud;
import java.lang.invoke.MethodHandles;
import java.util.Arrays;
+import java.util.Locale;
+import org.apache.solr.SolrTestCaseJ4;
import org.apache.solr.client.solrj.request.CollectionAdminRequest;
import org.apache.solr.core.TestSolrConfigHandler;
import org.apache.solr.util.LogLevel;
import org.apache.solr.util.PackageTool;
import org.apache.solr.util.SolrCLI;
+import org.apache.solr.util.SolrVersion;
import org.eclipse.jetty.server.Handler;
import org.eclipse.jetty.server.Server;
import org.eclipse.jetty.server.ServerConnector;
@@ -51,8 +54,18 @@ public class PackageManagerCLITest extends SolrCloudTestCase {
private static LocalWebServer repositoryServer;
+ @SuppressWarnings("AssertionFailureIgnored")
@BeforeClass
public static void setupCluster() throws Exception {
+ // Checks that semver4j works with configured locale */
+ try {
+ assertTrue(SolrVersion.valueOf("9.0.1").satisfies("~9.0"));
+ } catch (AssertionError e) {
+ SolrTestCaseJ4.assumeNoException(
+ "See SOLR-16467 - semver4j doesn't work with " + Locale.getDefault().toLanguageTag(),
+ new Exception(e));
+ }
+
System.setProperty("enable.packages", "true");
configureCluster(1)
@@ -69,8 +82,13 @@ public class PackageManagerCLITest extends SolrCloudTestCase {
@AfterClass
public static void teardown() throws Exception {
- repositoryServer.stop();
- System.clearProperty("enable.packages");
+ try {
+ if (repositoryServer != null) {
+ repositoryServer.stop();
+ }
+ } finally {
+ System.clearProperty("enable.packages");
+ }
}
@Test