You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2019/07/12 08:06:10 UTC
Re: Review Request 70820: Updated `filesystem/linux` isolator for
configurable IPC support.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70820/#review216550
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/containerizer/mesos/isolators/filesystem/linux.cpp
Lines 766 (patched)
<https://reviews.apache.org/r/70820/#comment303764>
You meant "not enabled"?
- Gilbert Song
On June 12, 2019, 7:32 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70820/
> -----------------------------------------------------------
>
> (Updated June 12, 2019, 7:32 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Gilbert Song.
>
>
> Bugs: MESOS-9826
> https://issues.apache.org/jira/browse/MESOS-9826
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If `namespaces/ipc` isolator is not enabled, for backward
> compatibility /dev/shm will still be handled in `filesystem/linux`
> isolator as before. Otherwise, both /dev/shm and IPC namespace
> will be handled by `namespaces/ipc` isolator.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 3cfb6e97a565420c8be2a0e31b481b39cd09d9da
>
>
> Diff: https://reviews.apache.org/r/70820/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>