You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/10/29 06:45:51 UTC
[GitHub] [iotdb] LebronAl opened a new pull request #1902: [Distributed] Fix create multi time series plan serialization
LebronAl opened a new pull request #1902:
URL: https://github.com/apache/iotdb/pull/1902
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] LebronAl commented on a change in pull request #1902: [Distributed] Fix create multi time series plan serialization
Posted by GitBox <gi...@apache.org>.
LebronAl commented on a change in pull request #1902:
URL: https://github.com/apache/iotdb/pull/1902#discussion_r514700947
##########
File path: server/src/main/java/org/apache/iotdb/db/qp/physical/sys/CreateMultiTimeSeriesPlan.java
##########
@@ -164,6 +164,7 @@ public void serialize(DataOutputStream stream) throws IOException {
if (alias != null) {
stream.write(1);
+ stream.writeInt(alias.size());
Review comment:
You are right~I misunderstood the code here,I will fix this.
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] mychaow commented on a change in pull request #1902: [Distributed] Fix create multi time series plan serialization
Posted by GitBox <gi...@apache.org>.
mychaow commented on a change in pull request #1902:
URL: https://github.com/apache/iotdb/pull/1902#discussion_r514676742
##########
File path: server/src/main/java/org/apache/iotdb/db/qp/physical/sys/CreateMultiTimeSeriesPlan.java
##########
@@ -164,6 +164,7 @@ public void serialize(DataOutputStream stream) throws IOException {
if (alias != null) {
stream.write(1);
+ stream.writeInt(alias.size());
Review comment:
If we support variable length of alias array, how to know which alias match the measurement? I think we should support the same size of alias array and measurement, but the alias can be null.
How do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] mychaow merged pull request #1902: [Distributed] Fix create multi time series plan serialization
Posted by GitBox <gi...@apache.org>.
mychaow merged pull request #1902:
URL: https://github.com/apache/iotdb/pull/1902
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org