You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/10/08 12:24:33 UTC
[GitHub] [flink] RocMarshal opened a new pull request, #20989: [FLINK-29548][flink-test-utils] Remove deprecated class files of the 'flink-test-utils' module.
RocMarshal opened a new pull request, #20989:
URL: https://github.com/apache/flink/pull/20989
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Remove deprecated class files of the 'flink-test-utils' module.
## Brief change log
*Only code-cleanup change.*
Delete
- flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/MiniClusterResource.java
- flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/MiniClusterResourceConfiguration.java
## Verifying this change
This change is a code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a diff in pull request #20989: [FLINK-29548][flink-test-utils] Remove deprecated class files of the 'flink-test-utils' module.
Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #20989:
URL: https://github.com/apache/flink/pull/20989#discussion_r993263767
##########
flink-table/flink-table-api-scala/src/main/scala/org/apache/flink/table/api/ImplicitExpressionConversions.scala:
##########
@@ -496,16 +496,16 @@ trait ImplicitExpressionConversions {
}
/**
- * Converts the date time string with format 'yyyy-MM-dd HH:mm:ss' under the 'UTC+0' time zone
- * to a timestamp value of [[DataTypes.TIMESTAMP]].
+ * Converts the date time string with format 'yyyy-MM-dd HH:mm:ss' under the 'UTC+0' time zone to
+ * a timestamp value of [[DataTypes.TIMESTAMP]].
Review Comment:
This was already fixed in 82e279ee.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RocMarshal commented on a diff in pull request #20989: [FLINK-29548][flink-test-utils] Remove deprecated class files of the 'flink-test-utils' module.
Posted by GitBox <gi...@apache.org>.
RocMarshal commented on code in PR #20989:
URL: https://github.com/apache/flink/pull/20989#discussion_r992912891
##########
flink-table/flink-table-api-scala/src/main/scala/org/apache/flink/table/api/ImplicitExpressionConversions.scala:
##########
@@ -496,16 +496,16 @@ trait ImplicitExpressionConversions {
}
/**
- * Converts the date time string with format 'yyyy-MM-dd HH:mm:ss' under the 'UTC+0' time zone
- * to a timestamp value of [[DataTypes.TIMESTAMP]].
+ * Converts the date time string with format 'yyyy-MM-dd HH:mm:ss' under the 'UTC+0' time zone to
+ * a timestamp value of [[DataTypes.TIMESTAMP]].
Review Comment:
https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=41746&view=logs&j=52b61abe-a3cc-5bde-cc35-1bbe89bb7df5&t=54421a62-0c80-5aad-3319-094ff69180bb
code style check failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RocMarshal commented on a diff in pull request #20989: [FLINK-29548][flink-test-utils] Remove deprecated class files of the 'flink-test-utils' module.
Posted by GitBox <gi...@apache.org>.
RocMarshal commented on code in PR #20989:
URL: https://github.com/apache/flink/pull/20989#discussion_r992911391
##########
flink-table/flink-table-api-scala/src/main/scala/org/apache/flink/table/api/ImplicitExpressionConversions.scala:
##########
@@ -496,16 +496,16 @@ trait ImplicitExpressionConversions {
}
/**
- * Converts the date time string with format 'yyyy-MM-dd HH:mm:ss' under the 'UTC+0' time zone
- * to a timestamp value of [[DataTypes.TIMESTAMP]].
+ * Converts the date time string with format 'yyyy-MM-dd HH:mm:ss' under the 'UTC+0' time zone to
+ * a timestamp value of [[DataTypes.TIMESTAMP]].
Review Comment:
https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=41747&view=logs&j=52b61abe-a3cc-5bde-cc35-1bbe89bb7df5&t=54421a62-0c80-5aad-3319-094ff69180bb
The code style check failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #20989: [FLINK-29548][flink-test-utils] Remove deprecated class files of the 'flink-test-utils' module.
Posted by GitBox <gi...@apache.org>.
zentol commented on PR #20989:
URL: https://github.com/apache/flink/pull/20989#issuecomment-1275980718
Please rebase the PR and then we can merge it I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a diff in pull request #20989: [FLINK-29548][flink-test-utils] Remove deprecated class files of the 'flink-test-utils' module.
Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #20989:
URL: https://github.com/apache/flink/pull/20989#discussion_r992377127
##########
flink-table/flink-table-api-scala/src/main/scala/org/apache/flink/table/api/ImplicitExpressionConversions.scala:
##########
@@ -496,16 +496,16 @@ trait ImplicitExpressionConversions {
}
/**
- * Converts the date time string with format 'yyyy-MM-dd HH:mm:ss' under the 'UTC+0' time zone
- * to a timestamp value of [[DataTypes.TIMESTAMP]].
+ * Converts the date time string with format 'yyyy-MM-dd HH:mm:ss' under the 'UTC+0' time zone to
+ * a timestamp value of [[DataTypes.TIMESTAMP]].
Review Comment:
What is this change about?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RocMarshal commented on pull request #20989: [FLINK-29548][flink-test-utils] Remove deprecated class files of the 'flink-test-utils' module.
Posted by GitBox <gi...@apache.org>.
RocMarshal commented on PR #20989:
URL: https://github.com/apache/flink/pull/20989#issuecomment-1272681554
@gaoyunhaii Could you help to check it ? thx~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #20989: [FLINK-29548][flink-test-utils] Remove deprecated class files of the 'flink-test-utils' module.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20989:
URL: https://github.com/apache/flink/pull/20989#issuecomment-1272308115
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "edd539a63fe3b04cc995d44e8524d011632817ed",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "edd539a63fe3b04cc995d44e8524d011632817ed",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* edd539a63fe3b04cc995d44e8524d011632817ed UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a diff in pull request #20989: [FLINK-29548][flink-test-utils] Remove deprecated class files of the 'flink-test-utils' module.
Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #20989:
URL: https://github.com/apache/flink/pull/20989#discussion_r993262882
##########
flink-table/flink-table-api-scala/src/main/scala/org/apache/flink/table/api/ImplicitExpressionConversions.scala:
##########
@@ -496,16 +496,16 @@ trait ImplicitExpressionConversions {
}
/**
- * Converts the date time string with format 'yyyy-MM-dd HH:mm:ss' under the 'UTC+0' time zone
- * to a timestamp value of [[DataTypes.TIMESTAMP]].
+ * Converts the date time string with format 'yyyy-MM-dd HH:mm:ss' under the 'UTC+0' time zone to
+ * a timestamp value of [[DataTypes.TIMESTAMP]].
Review Comment:
I also don't get it locally...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a diff in pull request #20989: [FLINK-29548][flink-test-utils] Remove deprecated class files of the 'flink-test-utils' module.
Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #20989:
URL: https://github.com/apache/flink/pull/20989#discussion_r993253330
##########
flink-table/flink-table-api-scala/src/main/scala/org/apache/flink/table/api/ImplicitExpressionConversions.scala:
##########
@@ -496,16 +496,16 @@ trait ImplicitExpressionConversions {
}
/**
- * Converts the date time string with format 'yyyy-MM-dd HH:mm:ss' under the 'UTC+0' time zone
- * to a timestamp value of [[DataTypes.TIMESTAMP]].
+ * Converts the date time string with format 'yyyy-MM-dd HH:mm:ss' under the 'UTC+0' time zone to
+ * a timestamp value of [[DataTypes.TIMESTAMP]].
Review Comment:
CI is passing though?
##########
flink-table/flink-table-api-scala/src/main/scala/org/apache/flink/table/api/ImplicitExpressionConversions.scala:
##########
@@ -496,16 +496,16 @@ trait ImplicitExpressionConversions {
}
/**
- * Converts the date time string with format 'yyyy-MM-dd HH:mm:ss' under the 'UTC+0' time zone
- * to a timestamp value of [[DataTypes.TIMESTAMP]].
+ * Converts the date time string with format 'yyyy-MM-dd HH:mm:ss' under the 'UTC+0' time zone to
+ * a timestamp value of [[DataTypes.TIMESTAMP]].
Review Comment:
CI is passing though on master?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #20989: [FLINK-29548][flink-test-utils] Remove deprecated class files of the 'flink-test-utils' module.
Posted by GitBox <gi...@apache.org>.
zentol merged PR #20989:
URL: https://github.com/apache/flink/pull/20989
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org