You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/08/23 18:27:33 UTC

[GitHub] [airflow] mik-laj commented on a change in pull request #5786: [AIRFLOW-5170] [AIRFLOW-5256] Consistent licences for python files and related pylint fixes

mik-laj commented on a change in pull request #5786:  [AIRFLOW-5170] [AIRFLOW-5256] Consistent licences for python files and related pylint fixes
URL: https://github.com/apache/airflow/pull/5786#discussion_r317252392
 
 

 ##########
 File path: airflow/contrib/hooks/qubole_hook.py
 ##########
 @@ -207,9 +214,10 @@ def get_jobs_id(self, ti):
         """
         if self.cmd is None:
             cmd_id = ti.xcom_pull(key="qbol_cmd_id", task_ids=self.task_id)
-        Command.get_jobs_id(self.cls, cmd_id)
+        Command.get_jobs_id(cmd_id)
 
-    def get_extra_links(self, operator, dttm):
+    @staticmethod
+    def get_extra_links(operator, dttm):
 
 Review comment:
   It's a part of interface of BaseOperator. Will this not cause regression?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services