[GitHub] [spark] HyukjinKwon commented on a diff in pull request #41606: [WIP] [SPARK-44061] Add assertDFEquality util function

["HyukjinKwon (via GitHub)" <gi...@apache.org>]

HyukjinKwon commented on code in PR #41606:
URL: https://github.com/apache/spark/pull/41606#discussion_r1250046113


##########
python/pyspark/sql/tests/test_utils.py:
##########
@@ -23,11 +23,100 @@
     IllegalArgumentException,
     SparkUpgradeException,
 )
+from pyspark.testing.utils import assertDFEquality
 from pyspark.testing.sqlutils import ReusedSQLTestCase
+from pyspark.testing.connectutils import ReusedConnectTestCase
+import pyspark.sql.functions as F
 from pyspark.sql.functions import to_date, unix_timestamp, from_unixtime
 
+import pandas as pd

Review Comment:
   This import should be within each test, and guarded by `pyspark.testing.sqlutils.pandas_requirement_message`, e.g.,
   
   ```python
   @unittest.skipIf(not have_pandas, pandas_requirement_message)  # type: ignore
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org