You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by to...@apache.org on 2016/01/11 10:19:13 UTC

[7/8] incubator-kudu git commit: cmake: relax version requirement

cmake: relax version requirement

In terms of raw feature set, cmake 3.2.0 is sufficient, and relaxing the
version requirement a bit allows cmake from Ubuntu 15.10 to be used.

Going forward let's use a new policy that is forgiving while still safe:
1. Require the oldest cmake that still satisfies Kudu's desired feature set.
2. Provide a cmake in thirdparty of the same version or newer.

Change-Id: I661f9d725abf8a31c82b308ceb7e6ef49a0551b4
Reviewed-on: http://gerrit.cloudera.org:8080/1733
Tested-by: Internal Jenkins
Reviewed-by: Todd Lipcon <to...@cloudera.com>


Project: http://git-wip-us.apache.org/repos/asf/incubator-kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kudu/commit/d4de1cd6
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kudu/tree/d4de1cd6
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kudu/diff/d4de1cd6

Branch: refs/heads/master
Commit: d4de1cd6170c07b1828b3a3855897139c790e2dd
Parents: 1e03310
Author: Adar Dembo <ad...@cloudera.com>
Authored: Wed Jan 6 22:15:35 2016 -0800
Committer: Todd Lipcon <to...@cloudera.com>
Committed: Fri Jan 8 19:43:27 2016 +0000

----------------------------------------------------------------------
 CMakeLists.txt | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/d4de1cd6/CMakeLists.txt
----------------------------------------------------------------------
diff --git a/CMakeLists.txt b/CMakeLists.txt
index a25cdaa..90ea9c9 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -15,8 +15,12 @@
 # specific language governing permissions and limitations
 # under the License.
 
-# Require cmake at least as new as the one in thirdparty/
-cmake_minimum_required(VERSION 3.2.3)
+# Require cmake that supports BYPRODUCTS in add_custom_command() [1].
+#
+# Note: cmake in thirdparty/ will always meet this minimum.
+#
+# 1. https://cmake.org/Bug/view.php?id=14963
+cmake_minimum_required(VERSION 3.2.0)
 
 # TODO: can we somehow pass this into the java build?
 set(KUDU_VERSION_NUMBER "0.7.0-SNAPSHOT")