[GitHub] [spark] dongjoon-hyun commented on a change in pull request #31942: [SPARK-34834][NETWORK] Fix a potential Netty memory leak in TransportResponseHandler.

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #31942:
URL: https://github.com/apache/spark/pull/31942#discussion_r602010302



##########
File path: common/network-common/src/main/java/org/apache/spark/network/client/TransportResponseHandler.java
##########
@@ -188,6 +188,7 @@ public void handle(ResponseMessage message) throws Exception {
       if (listener == null) {
         logger.warn("Ignoring response for RPC {} from {} ({} bytes) since it is not outstanding",
           resp.requestId, getRemoteAddress(channel), resp.body().size());
+        resp.body().release();

Review comment:
       From the commit history, is this missed since Apache Spark 1.2.0 at SPARK-3453?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org