You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Steve Carlin (Code Review)" <ge...@cloudera.org> on 2025/09/10 00:30:09 UTC

[Impala-ASF-CR] WIP: test removal of code to see what breaks

Steve Carlin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23408


Change subject: WIP: test removal of code to see what breaks
......................................................................

WIP: test removal of code to see what breaks

Change-Id: Ia36ba5db489e91d635d7d0972d1f071140afac9f
---
M java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java
M java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/FunctionResolver.java
M java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/RexCallConverter.java
M java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaProjectRel.java
M java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaValuesRel.java
M java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/util/TupleDescriptorFactory.java
M java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaCoreRules.java
D java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaIntersectToDistinctRule.java
M java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ReduceExprShuttle.java
M java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java
M java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeConverter.java
11 files changed, 32 insertions(+), 290 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/23408/1
-- 
To view, visit http://gerrit.cloudera.org:8080/23408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia36ba5db489e91d635d7d0972d1f071140afac9f
Gerrit-Change-Number: 23408
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>

[Impala-ASF-CR] WIP: test removal of code to see what breaks

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23408 )

Change subject: WIP: test removal of code to see what breaks
......................................................................


Patch Set 16:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/20483/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/23408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia36ba5db489e91d635d7d0972d1f071140afac9f
Gerrit-Change-Number: 23408
Gerrit-PatchSet: 16
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Sep 2025 13:39:55 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] WIP: test removal of code to see what breaks

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23408 )

Change subject: WIP: test removal of code to see what breaks
......................................................................


Patch Set 1: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/12455/


-- 
To view, visit http://gerrit.cloudera.org:8080/23408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia36ba5db489e91d635d7d0972d1f071140afac9f
Gerrit-Change-Number: 23408
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 Sep 2025 02:25:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] WIP: test removal of code to see what breaks

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23408 )

Change subject: WIP: test removal of code to see what breaks
......................................................................


Patch Set 6:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/20454/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/23408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia36ba5db489e91d635d7d0972d1f071140afac9f
Gerrit-Change-Number: 23408
Gerrit-PatchSet: 6
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Sep 2025 20:01:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] WIP: test removal of code to see what breaks

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23408 )

Change subject: WIP: test removal of code to see what breaks
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12455/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/23408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia36ba5db489e91d635d7d0972d1f071140afac9f
Gerrit-Change-Number: 23408
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 Sep 2025 00:30:54 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] WIP: test removal of code to see what breaks

Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23408

to look at the new patch set (#6).

Change subject: WIP: test removal of code to see what breaks
......................................................................

WIP: test removal of code to see what breaks

Change-Id: Ia36ba5db489e91d635d7d0972d1f071140afac9f
---
M java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java
M java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java
M java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ReduceExprShuttle.java
M java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeCoercionImpl.java
4 files changed, 41 insertions(+), 42 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/23408/6
-- 
To view, visit http://gerrit.cloudera.org:8080/23408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia36ba5db489e91d635d7d0972d1f071140afac9f
Gerrit-Change-Number: 23408
Gerrit-PatchSet: 6
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] WIP: test removal of code to see what breaks

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23408 )

Change subject: WIP: test removal of code to see what breaks
......................................................................


Patch Set 6: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/12469/


-- 
To view, visit http://gerrit.cloudera.org:8080/23408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia36ba5db489e91d635d7d0972d1f071140afac9f
Gerrit-Change-Number: 23408
Gerrit-PatchSet: 6
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Sep 2025 02:21:00 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] WIP: test removal of code to see what breaks

Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23408

to look at the new patch set (#2).

Change subject: WIP: test removal of code to see what breaks
......................................................................

WIP: test removal of code to see what breaks

Change-Id: Ia36ba5db489e91d635d7d0972d1f071140afac9f
---
M java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java
M java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/FunctionResolver.java
M java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/RexCallConverter.java
M java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/util/TupleDescriptorFactory.java
M java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ReduceExprShuttle.java
M java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeConverter.java
6 files changed, 4 insertions(+), 68 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/23408/2
-- 
To view, visit http://gerrit.cloudera.org:8080/23408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia36ba5db489e91d635d7d0972d1f071140afac9f
Gerrit-Change-Number: 23408
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] WIP: test removal of code to see what breaks

Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23408

to look at the new patch set (#8).

Change subject: WIP: test removal of code to see what breaks
......................................................................

WIP: test removal of code to see what breaks

Change-Id: Ia36ba5db489e91d635d7d0972d1f071140afac9f
---
M java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaRexBuilder.java
M java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ReduceExprShuttle.java
M java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java
M java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java
4 files changed, 11 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/23408/8
-- 
To view, visit http://gerrit.cloudera.org:8080/23408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia36ba5db489e91d635d7d0972d1f071140afac9f
Gerrit-Change-Number: 23408
Gerrit-PatchSet: 8
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] WIP: test removal of code to see what breaks

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23408 )

Change subject: WIP: test removal of code to see what breaks
......................................................................


Patch Set 8:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/20469/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/23408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia36ba5db489e91d635d7d0972d1f071140afac9f
Gerrit-Change-Number: 23408
Gerrit-PatchSet: 8
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Sep 2025 18:42:36 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] WIP: test removal of code to see what breaks

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23408 )

Change subject: WIP: test removal of code to see what breaks
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/20441/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/23408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia36ba5db489e91d635d7d0972d1f071140afac9f
Gerrit-Change-Number: 23408
Gerrit-PatchSet: 3
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 Sep 2025 23:08:58 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] WIP: test removal of code to see what breaks

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23408 )

Change subject: WIP: test removal of code to see what breaks
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12463/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/23408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia36ba5db489e91d635d7d0972d1f071140afac9f
Gerrit-Change-Number: 23408
Gerrit-PatchSet: 4
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Sep 2025 01:07:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] WIP: test removal of code to see what breaks

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23408 )

Change subject: WIP: test removal of code to see what breaks
......................................................................


Patch Set 4: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/12463/


-- 
To view, visit http://gerrit.cloudera.org:8080/23408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia36ba5db489e91d635d7d0972d1f071140afac9f
Gerrit-Change-Number: 23408
Gerrit-PatchSet: 4
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Sep 2025 07:51:44 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] WIP: test removal of code to see what breaks

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23408 )

Change subject: WIP: test removal of code to see what breaks
......................................................................


Patch Set 5:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/20449/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/23408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia36ba5db489e91d635d7d0972d1f071140afac9f
Gerrit-Change-Number: 23408
Gerrit-PatchSet: 5
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Sep 2025 14:35:25 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] WIP: test removal of code to see what breaks

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23408 )

Change subject: WIP: test removal of code to see what breaks
......................................................................


Patch Set 1:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/20429/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/23408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia36ba5db489e91d635d7d0972d1f071140afac9f
Gerrit-Change-Number: 23408
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 Sep 2025 00:50:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] WIP: test removal of code to see what breaks

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23408 )

Change subject: WIP: test removal of code to see what breaks
......................................................................


Patch Set 5: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/12466/


-- 
To view, visit http://gerrit.cloudera.org:8080/23408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia36ba5db489e91d635d7d0972d1f071140afac9f
Gerrit-Change-Number: 23408
Gerrit-PatchSet: 5
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Sep 2025 20:48:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] WIP: test removal of code to see what breaks

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23408 )

Change subject: WIP: test removal of code to see what breaks
......................................................................


Patch Set 2: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/12456/


-- 
To view, visit http://gerrit.cloudera.org:8080/23408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia36ba5db489e91d635d7d0972d1f071140afac9f
Gerrit-Change-Number: 23408
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 Sep 2025 07:38:29 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] WIP: test removal of code to see what breaks

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23408 )

Change subject: WIP: test removal of code to see what breaks
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/20431/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/23408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia36ba5db489e91d635d7d0972d1f071140afac9f
Gerrit-Change-Number: 23408
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 Sep 2025 02:46:09 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] WIP: test removal of code to see what breaks

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23408 )

Change subject: WIP: test removal of code to see what breaks
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12456/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/23408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia36ba5db489e91d635d7d0972d1f071140afac9f
Gerrit-Change-Number: 23408
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 Sep 2025 02:18:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] WIP: test removal of code to see what breaks

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23408 )

Change subject: WIP: test removal of code to see what breaks
......................................................................


Patch Set 13:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/20474/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/23408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia36ba5db489e91d635d7d0972d1f071140afac9f
Gerrit-Change-Number: 23408
Gerrit-PatchSet: 13
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 13 Sep 2025 18:49:46 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] WIP: test removal of code to see what breaks

Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23408

to look at the new patch set (#5).

Change subject: WIP: test removal of code to see what breaks
......................................................................

WIP: test removal of code to see what breaks

Change-Id: Ia36ba5db489e91d635d7d0972d1f071140afac9f
---
M java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java
M java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ReduceExprShuttle.java
2 files changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/23408/5
-- 
To view, visit http://gerrit.cloudera.org:8080/23408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia36ba5db489e91d635d7d0972d1f071140afac9f
Gerrit-Change-Number: 23408
Gerrit-PatchSet: 5
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] WIP: test removal of code to see what breaks

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23408 )

Change subject: WIP: test removal of code to see what breaks
......................................................................


Patch Set 17:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/20491/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/23408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia36ba5db489e91d635d7d0972d1f071140afac9f
Gerrit-Change-Number: 23408
Gerrit-PatchSet: 17
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Sep 2025 01:51:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] WIP: test removal of code to see what breaks

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23408 )

Change subject: WIP: test removal of code to see what breaks
......................................................................


Patch Set 13:

(1 comment)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/23408/13/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java
File java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java:

http://gerrit.cloudera.org:8080/#/c/23408/13/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java@241
PS13, Line 241:     RelDataType retType = ImpalaTypeConverter.createRelDataType(factory, impalaReturnType);
line too long (91 > 90)



-- 
To view, visit http://gerrit.cloudera.org:8080/23408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia36ba5db489e91d635d7d0972d1f071140afac9f
Gerrit-Change-Number: 23408
Gerrit-PatchSet: 13
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 13 Sep 2025 18:28:14 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] WIP: test removal of code to see what breaks

Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23408

to look at the new patch set (#3).

Change subject: WIP: test removal of code to see what breaks
......................................................................

WIP: test removal of code to see what breaks

Change-Id: Ia36ba5db489e91d635d7d0972d1f071140afac9f
---
M java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaProjectRel.java
M java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaValuesRel.java
M java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ReduceExprShuttle.java
3 files changed, 23 insertions(+), 61 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/23408/3
-- 
To view, visit http://gerrit.cloudera.org:8080/23408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia36ba5db489e91d635d7d0972d1f071140afac9f
Gerrit-Change-Number: 23408
Gerrit-PatchSet: 3
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] WIP: test removal of code to see what breaks

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23408 )

Change subject: WIP: test removal of code to see what breaks
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/20443/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/23408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia36ba5db489e91d635d7d0972d1f071140afac9f
Gerrit-Change-Number: 23408
Gerrit-PatchSet: 4
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Sep 2025 01:34:13 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] WIP: test removal of code to see what breaks

Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Steve Carlin has abandoned this change. ( http://gerrit.cloudera.org:8080/23408 )

Change subject: WIP: test removal of code to see what breaks
......................................................................


Abandoned
-- 
To view, visit http://gerrit.cloudera.org:8080/23408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ia36ba5db489e91d635d7d0972d1f071140afac9f
Gerrit-Change-Number: 23408
Gerrit-PatchSet: 23
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] WIP: test removal of code to see what breaks

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23408 )

Change subject: WIP: test removal of code to see what breaks
......................................................................


Patch Set 5:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12466/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/23408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia36ba5db489e91d635d7d0972d1f071140afac9f
Gerrit-Change-Number: 23408
Gerrit-PatchSet: 5
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Sep 2025 14:06:08 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] WIP: test removal of code to see what breaks

Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23408

to look at the new patch set (#4).

Change subject: WIP: test removal of code to see what breaks
......................................................................

WIP: test removal of code to see what breaks

Change-Id: Ia36ba5db489e91d635d7d0972d1f071140afac9f
---
M java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ExpandInFunctionShuttle.java
M java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ReduceExprShuttle.java
2 files changed, 9 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/23408/4
-- 
To view, visit http://gerrit.cloudera.org:8080/23408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia36ba5db489e91d635d7d0972d1f071140afac9f
Gerrit-Change-Number: 23408
Gerrit-PatchSet: 4
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] WIP: test removal of code to see what breaks

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23408 )

Change subject: WIP: test removal of code to see what breaks
......................................................................


Patch Set 6:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12469/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/23408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia36ba5db489e91d635d7d0972d1f071140afac9f
Gerrit-Change-Number: 23408
Gerrit-PatchSet: 6
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Sep 2025 19:30:13 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] WIP: test removal of code to see what breaks

Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23408

to look at the new patch set (#13).

Change subject: WIP: test removal of code to see what breaks
......................................................................

WIP: test removal of code to see what breaks

Change-Id: Ia36ba5db489e91d635d7d0972d1f071140afac9f
---
M java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java
M java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeCoercionImpl.java
M java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeConverter.java
3 files changed, 59 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/23408/13
-- 
To view, visit http://gerrit.cloudera.org:8080/23408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia36ba5db489e91d635d7d0972d1f071140afac9f
Gerrit-Change-Number: 23408
Gerrit-PatchSet: 13
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] WIP: test removal of code to see what breaks

Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23408

to look at the new patch set (#16).

Change subject: WIP: test removal of code to see what breaks
......................................................................

WIP: test removal of code to see what breaks

Change-Id: Ia36ba5db489e91d635d7d0972d1f071140afac9f
---
M java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java
M java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ExpandInFunctionShuttle.java
2 files changed, 18 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/23408/16
-- 
To view, visit http://gerrit.cloudera.org:8080/23408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia36ba5db489e91d635d7d0972d1f071140afac9f
Gerrit-Change-Number: 23408
Gerrit-PatchSet: 16
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] WIP: test removal of code to see what breaks

Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23408

to look at the new patch set (#17).

Change subject: WIP: test removal of code to see what breaks
......................................................................

WIP: test removal of code to see what breaks

Change-Id: Ia36ba5db489e91d635d7d0972d1f071140afac9f
---
M java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java
M java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ExpandInFunctionShuttle.java
M java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeCoercionImpl.java
3 files changed, 33 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/23408/17
-- 
To view, visit http://gerrit.cloudera.org:8080/23408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia36ba5db489e91d635d7d0972d1f071140afac9f
Gerrit-Change-Number: 23408
Gerrit-PatchSet: 17
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>