[GitHub] [shardingsphere] yu199195 commented on a change in pull request #8693: Fix parseDateTime error when sharding value is Date or LocalDateTime

[GitBox <gi...@apache.org>]

yu199195 commented on a change in pull request #8693:
URL: https://github.com/apache/shardingsphere/pull/8693#discussion_r555009669



##########
File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-common/src/main/java/org/apache/shardingsphere/sharding/algorithm/sharding/datetime/AutoIntervalShardingAlgorithm.java
##########
@@ -124,7 +126,16 @@ private int getLastPartition(final Range<Comparable<?>> valueRange) {
     }
     
     private long parseDate(final Comparable<?> shardingValue) {
-        LocalDateTime dateValue = LocalDateTime.parse(shardingValue.toString(), DATE_TIME_FORMAT);
+        LocalDateTime dateValue;

Review comment:
       so this pr ,we can not merged, Do you have any other fix,  if not can you close this pr?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org