You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "Zhao Yongming (Created) (JIRA)" <ji...@apache.org> on 2012/03/07 16:10:58 UTC
[jira] [Created] (TS-1130) ink_time_t is 64bit on x86_64
ink_time_t is 64bit on x86_64
-----------------------------
Key: TS-1130
URL: https://issues.apache.org/jira/browse/TS-1130
Project: Traffic Server
Issue Type: Sub-task
Reporter: Zhao Yongming
Assignee: weijin
Fix For: 3.1.3
Weijin: paste your patch here, :D
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1130) ink_time_t is 64bit on x86_64
Posted by "Leif Hedstrom (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257996#comment-13257996 ]
Leif Hedstrom commented on TS-1130:
-----------------------------------
Looks good to me. I couldn't see any other places where we use the atomic CAS on an ink_time_t, so this should be fine. Wei Jin, I'd say commit it! (Assuming you've tested it).
> ink_time_t is 64bit on x86_64
> -----------------------------
>
> Key: TS-1130
> URL: https://issues.apache.org/jira/browse/TS-1130
> Project: Traffic Server
> Issue Type: Sub-task
> Components: Core
> Reporter: Zhao Yongming
> Assignee: weijin
> Fix For: 3.1.4
>
> Attachments: TS-1130.diff
>
>
> Weijin: paste your patch here, :D
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1130) ink_time_t is 64bit on x86_64
Posted by "Leif Hedstrom (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250221#comment-13250221 ]
Leif Hedstrom commented on TS-1130:
-----------------------------------
yes, where's the patch? :)
> ink_time_t is 64bit on x86_64
> -----------------------------
>
> Key: TS-1130
> URL: https://issues.apache.org/jira/browse/TS-1130
> Project: Traffic Server
> Issue Type: Sub-task
> Components: Core
> Reporter: Zhao Yongming
> Assignee: weijin
> Fix For: 3.1.4
>
>
> Weijin: paste your patch here, :D
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1130) ink_time_t is 64bit on x86_64
Posted by "weijin (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258130#comment-13258130 ]
weijin commented on TS-1130:
----------------------------
According Leif`s advice, by checking the sizeof() on ink_time_t before the atomic CAS.
> ink_time_t is 64bit on x86_64
> -----------------------------
>
> Key: TS-1130
> URL: https://issues.apache.org/jira/browse/TS-1130
> Project: Traffic Server
> Issue Type: Sub-task
> Components: Core
> Reporter: Zhao Yongming
> Assignee: weijin
> Fix For: 3.1.4
>
> Attachments: TS-1130.diff
>
>
> Weijin: paste your patch here, :D
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1130) ink_time_t is 64bit on x86_64
Posted by "weijin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258694#comment-13258694 ]
weijin commented on TS-1130:
----------------------------
try2 have a compile error, blame me.
> ink_time_t is 64bit on x86_64
> -----------------------------
>
> Key: TS-1130
> URL: https://issues.apache.org/jira/browse/TS-1130
> Project: Traffic Server
> Issue Type: Sub-task
> Components: Core
> Reporter: Zhao Yongming
> Assignee: weijin
> Fix For: 3.1.4
>
> Attachments: TS-1130.diff, TS-1130.try2.diff, TS-1130.try3.diff
>
>
> Weijin: paste your patch here, :D
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1130) ink_time_t is 64bit on x86_64
Posted by "weijin (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250553#comment-13250553 ]
weijin commented on TS-1130:
----------------------------
We found in some 64 bit systems, the ink_atomic_cas on time_t variable can lead very strange problems, such as endless loop.
> ink_time_t is 64bit on x86_64
> -----------------------------
>
> Key: TS-1130
> URL: https://issues.apache.org/jira/browse/TS-1130
> Project: Traffic Server
> Issue Type: Sub-task
> Components: Core
> Reporter: Zhao Yongming
> Assignee: weijin
> Fix For: 3.1.4
>
> Attachments: TS-1130.diff
>
>
> Weijin: paste your patch here, :D
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1130) ink_time_t is 64bit on x86_64
Posted by "weijin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
weijin updated TS-1130:
-----------------------
Attachment: TS-1130.try3.diff
> ink_time_t is 64bit on x86_64
> -----------------------------
>
> Key: TS-1130
> URL: https://issues.apache.org/jira/browse/TS-1130
> Project: Traffic Server
> Issue Type: Sub-task
> Components: Core
> Reporter: Zhao Yongming
> Assignee: weijin
> Fix For: 3.1.4
>
> Attachments: TS-1130.diff, TS-1130.try2.diff, TS-1130.try3.diff
>
>
> Weijin: paste your patch here, :D
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1130) ink_time_t is 64bit on x86_64
Posted by "weijin (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
weijin updated TS-1130:
-----------------------
Attachment: TS-1130.diff
time_t in x86_64 is 64 bit. If we use the 64 bit atomic operation on time_t variables.
> ink_time_t is 64bit on x86_64
> -----------------------------
>
> Key: TS-1130
> URL: https://issues.apache.org/jira/browse/TS-1130
> Project: Traffic Server
> Issue Type: Sub-task
> Components: Core
> Reporter: Zhao Yongming
> Assignee: weijin
> Fix For: 3.1.4
>
> Attachments: TS-1130.diff
>
>
> Weijin: paste your patch here, :D
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1130) ink_time_t is 64bit on x86_64
Posted by "Leif Hedstrom (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom updated TS-1130:
------------------------------
Fix Version/s: (was: 3.1.3)
3.1.4
> ink_time_t is 64bit on x86_64
> -----------------------------
>
> Key: TS-1130
> URL: https://issues.apache.org/jira/browse/TS-1130
> Project: Traffic Server
> Issue Type: Sub-task
> Components: Core
> Reporter: Zhao Yongming
> Assignee: weijin
> Fix For: 3.1.4
>
>
> Weijin: paste your patch here, :D
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1130) ink_time_t is 64bit on x86_64
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258724#comment-13258724 ]
Leif Hedstrom commented on TS-1130:
-----------------------------------
Looks good, commit it.
> ink_time_t is 64bit on x86_64
> -----------------------------
>
> Key: TS-1130
> URL: https://issues.apache.org/jira/browse/TS-1130
> Project: Traffic Server
> Issue Type: Sub-task
> Components: Core
> Reporter: Zhao Yongming
> Assignee: weijin
> Fix For: 3.1.4
>
> Attachments: TS-1130.diff, TS-1130.try2.diff, TS-1130.try3.diff
>
>
> Weijin: paste your patch here, :D
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1130) ink_time_t is 64bit on x86_64
Posted by "weijin (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
weijin updated TS-1130:
-----------------------
Attachment: TS-1130.try2.diff
> ink_time_t is 64bit on x86_64
> -----------------------------
>
> Key: TS-1130
> URL: https://issues.apache.org/jira/browse/TS-1130
> Project: Traffic Server
> Issue Type: Sub-task
> Components: Core
> Reporter: Zhao Yongming
> Assignee: weijin
> Fix For: 3.1.4
>
> Attachments: TS-1130.diff, TS-1130.try2.diff
>
>
> Weijin: paste your patch here, :D
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (TS-1130) ink_time_t is 64bit on x86_64
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom closed TS-1130.
-----------------------------
Resolution: Fixed
Assignee: (was: weijin)
I believe this is fixed, so closing it.
> ink_time_t is 64bit on x86_64
> -----------------------------
>
> Key: TS-1130
> URL: https://issues.apache.org/jira/browse/TS-1130
> Project: Traffic Server
> Issue Type: Sub-task
> Components: Core
> Reporter: Zhao Yongming
> Fix For: 3.1.4
>
> Attachments: TS-1130.diff, TS-1130.try2.diff, TS-1130.try3.diff
>
>
> Weijin: paste your patch here, :D
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1130) ink_time_t is 64bit on x86_64
Posted by "Leif Hedstrom (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257998#comment-13257998 ]
Leif Hedstrom commented on TS-1130:
-----------------------------------
Although, maybe you should check the sizeof() on ink_time_t instead of assuming it's the defined by WORDSIZE?
> ink_time_t is 64bit on x86_64
> -----------------------------
>
> Key: TS-1130
> URL: https://issues.apache.org/jira/browse/TS-1130
> Project: Traffic Server
> Issue Type: Sub-task
> Components: Core
> Reporter: Zhao Yongming
> Assignee: weijin
> Fix For: 3.1.4
>
> Attachments: TS-1130.diff
>
>
> Weijin: paste your patch here, :D
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira