You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by zh...@apache.org on 2023/05/18 05:45:48 UTC

[shardingsphere] branch master updated: Fix sonar issue of AssignmentSegment (#25757)

This is an automated email from the ASF dual-hosted git repository.

zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 2780f565cbf Fix sonar issue of AssignmentSegment (#25757)
2780f565cbf is described below

commit 2780f565cbfbca2f1ef597754deb82c851a804f4
Author: Liang Zhang <zh...@apache.org>
AuthorDate: Thu May 18 13:45:39 2023 +0800

    Fix sonar issue of AssignmentSegment (#25757)
---
 .../parser/sql/common/segment/dml/assignment/AssignmentSegment.java | 6 +++---
 .../sql/common/segment/dml/assignment/ColumnAssignmentSegment.java  | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/parser/sql/statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/segment/dml/assignment/AssignmentSegment.java b/parser/sql/statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/segment/dml/assignment/AssignmentSegment.java
index 6d2f1c3b0bd..7ad440abf14 100644
--- a/parser/sql/statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/segment/dml/assignment/AssignmentSegment.java
+++ b/parser/sql/statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/segment/dml/assignment/AssignmentSegment.java
@@ -26,19 +26,19 @@ import java.util.List;
 /**
  * Assignment segment.
  */
-public abstract class AssignmentSegment implements SQLSegment {
+public interface AssignmentSegment extends SQLSegment {
     
     /**
      * Get list of column segments.
      * 
      * @return list of ColumnSegment
      */
-    public abstract List<ColumnSegment> getColumns();
+    List<ColumnSegment> getColumns();
     
     /**
      * Get expression segment value.
      * 
      * @return ExpressionSegment
      */
-    public abstract ExpressionSegment getValue();
+    ExpressionSegment getValue();
 }
diff --git a/parser/sql/statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/segment/dml/assignment/ColumnAssignmentSegment.java b/parser/sql/statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/segment/dml/assignment/ColumnAssignmentSegment.java
index 1e3dab1a90d..db6585a8437 100644
--- a/parser/sql/statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/segment/dml/assignment/ColumnAssignmentSegment.java
+++ b/parser/sql/statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/segment/dml/assignment/ColumnAssignmentSegment.java
@@ -29,7 +29,7 @@ import java.util.List;
  */
 @RequiredArgsConstructor
 @Getter
-public final class ColumnAssignmentSegment extends AssignmentSegment {
+public final class ColumnAssignmentSegment implements AssignmentSegment {
     
     private final int startIndex;