You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "David Bosschaert (JIRA)" <ji...@apache.org> on 2009/06/25 22:00:07 UTC
[jira] Created: (FELIX-1277) Fix Service Hooks Tests failures in
RFC 126 TCK
Fix Service Hooks Tests failures in RFC 126 TCK
-----------------------------------------------
Key: FELIX-1277
URL: https://issues.apache.org/jira/browse/FELIX-1277
Project: Felix
Issue Type: Bug
Components: Framework
Affects Versions: felix-1.8.1
Reporter: David Bosschaert
Attachments: servicehooktests_fixes.patch
6 out of 7 of the TCK Service Hook Tests are failing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-1277) Fix Service Hooks Tests failures in
RFC 126 TCK
Posted by "David Bosschaert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Bosschaert updated FELIX-1277:
------------------------------------
Attachment: rfc126_tck_fixes.patch
A new version of the changes that fix the RFC 126 failures. This one is a lot leaner than the previous version of this patch which I have removed.
Thanks to Richard for keeping me on my toes :)
> Fix Service Hooks Tests failures in RFC 126 TCK
> -----------------------------------------------
>
> Key: FELIX-1277
> URL: https://issues.apache.org/jira/browse/FELIX-1277
> Project: Felix
> Issue Type: Bug
> Components: Framework
> Affects Versions: felix-1.8.1
> Reporter: David Bosschaert
> Attachments: rfc126_tck_fixes.patch
>
>
> 6 out of 7 of the TCK Service Hook Tests are failing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-1277) Fix Service Hooks Tests failures in
RFC 126 TCK
Posted by "David Bosschaert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Bosschaert updated FELIX-1277:
------------------------------------
Attachment: (was: servicehooktests_fixes.patch)
> Fix Service Hooks Tests failures in RFC 126 TCK
> -----------------------------------------------
>
> Key: FELIX-1277
> URL: https://issues.apache.org/jira/browse/FELIX-1277
> Project: Felix
> Issue Type: Bug
> Components: Framework
> Affects Versions: felix-1.8.1
> Reporter: David Bosschaert
>
> 6 out of 7 of the TCK Service Hook Tests are failing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (FELIX-1277) Fix Service Hooks Tests failures in RFC
126 TCK
Posted by "David Bosschaert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Bosschaert closed FELIX-1277.
-----------------------------------
Thanks,
David
> Fix Service Hooks Tests failures in RFC 126 TCK
> -----------------------------------------------
>
> Key: FELIX-1277
> URL: https://issues.apache.org/jira/browse/FELIX-1277
> Project: Felix
> Issue Type: Bug
> Components: Framework
> Affects Versions: felix-1.8.1
> Reporter: David Bosschaert
> Assignee: Richard S. Hall
> Fix For: felix-2.0.0
>
> Attachments: rfc126_tck_fixes_3.patch
>
>
> 6 out of 7 of the TCK Service Hook Tests are failing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-1277) Fix Service Hooks Tests failures in
RFC 126 TCK
Posted by "David Bosschaert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Bosschaert updated FELIX-1277:
------------------------------------
Attachment: rfc126_tck_fixes_3.patch
> Fix Service Hooks Tests failures in RFC 126 TCK
> -----------------------------------------------
>
> Key: FELIX-1277
> URL: https://issues.apache.org/jira/browse/FELIX-1277
> Project: Felix
> Issue Type: Bug
> Components: Framework
> Affects Versions: felix-1.8.1
> Reporter: David Bosschaert
> Attachments: rfc126_tck_fixes_3.patch
>
>
> 6 out of 7 of the TCK Service Hook Tests are failing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-1277) Fix Service Hooks Tests failures in
RFC 126 TCK
Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Richard S. Hall updated FELIX-1277:
-----------------------------------
Fix Version/s: felix-2.0.0
Assignee: Richard S. Hall
> Fix Service Hooks Tests failures in RFC 126 TCK
> -----------------------------------------------
>
> Key: FELIX-1277
> URL: https://issues.apache.org/jira/browse/FELIX-1277
> Project: Felix
> Issue Type: Bug
> Components: Framework
> Affects Versions: felix-1.8.1
> Reporter: David Bosschaert
> Assignee: Richard S. Hall
> Fix For: felix-2.0.0
>
> Attachments: rfc126_tck_fixes_3.patch
>
>
> 6 out of 7 of the TCK Service Hook Tests are failing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-1277) Fix Service Hooks Tests failures in
RFC 126 TCK
Posted by "David Bosschaert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Bosschaert updated FELIX-1277:
------------------------------------
Attachment: servicehooktests_fixes.patch
The attached patch contains a fix for this. All 7 TCK tests pass with this.
> Fix Service Hooks Tests failures in RFC 126 TCK
> -----------------------------------------------
>
> Key: FELIX-1277
> URL: https://issues.apache.org/jira/browse/FELIX-1277
> Project: Felix
> Issue Type: Bug
> Components: Framework
> Affects Versions: felix-1.8.1
> Reporter: David Bosschaert
> Attachments: servicehooktests_fixes.patch
>
>
> 6 out of 7 of the TCK Service Hook Tests are failing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (FELIX-1277) Fix Service Hooks Tests failures in
RFC 126 TCK
Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Richard S. Hall resolved FELIX-1277.
------------------------------------
Resolution: Fixed
I committed this patch with modifications. I tried to simplify it by using references rather than registrations for the internal data structures and method parameters. This made sense since the service hooks are acquired like any normal service with a call to getService(). It also allowed me to eliminate the one comparator class, since reference already implements comparable. I also changed the maps holding hooks to sorted sets, since we weren't really using the value. I would like to investigate further simplifying these hooks, but I think it would take more changes to the service registry.
At any rate, it now passes the hooks test suite. Please close if you are satisfied. Thanks a lot!
> Fix Service Hooks Tests failures in RFC 126 TCK
> -----------------------------------------------
>
> Key: FELIX-1277
> URL: https://issues.apache.org/jira/browse/FELIX-1277
> Project: Felix
> Issue Type: Bug
> Components: Framework
> Affects Versions: felix-1.8.1
> Reporter: David Bosschaert
> Assignee: Richard S. Hall
> Fix For: felix-2.0.0
>
> Attachments: rfc126_tck_fixes_3.patch
>
>
> 6 out of 7 of the TCK Service Hook Tests are failing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-1277) Fix Service Hooks Tests failures in
RFC 126 TCK
Posted by "David Bosschaert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Bosschaert updated FELIX-1277:
------------------------------------
Attachment: (was: rfc126_tck_fixes.patch)
> Fix Service Hooks Tests failures in RFC 126 TCK
> -----------------------------------------------
>
> Key: FELIX-1277
> URL: https://issues.apache.org/jira/browse/FELIX-1277
> Project: Felix
> Issue Type: Bug
> Components: Framework
> Affects Versions: felix-1.8.1
> Reporter: David Bosschaert
>
> 6 out of 7 of the TCK Service Hook Tests are failing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.