You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sedona.apache.org by GitBox <gi...@apache.org> on 2022/06/17 14:59:38 UTC

[GitHub] [incubator-sedona] umartin opened a new pull request, #635: [SEDONA-128] Change Sedona python code to support pyspark 3.3

umartin opened a new pull request, #635:
URL: https://github.com/apache/incubator-sedona/pull/635

   
   ## Did you read the Contributor Guide?
   
   - Yes, I have read [Contributor Rules](https://sedona.apache.org/community/rule/) and [Contributor Development Guide](https://sedona.apache.org/community/develop/)
   
   ## Is this PR related to a JIRA ticket?
   
   - Yes, the URL of the assoicated JIRA ticket is https://issues.apache.org/jira/browse/SEDONA-128. The PR name follows the format `[SEDONA-128] my subject`.
   
   ## What changes were proposed in this PR?
   
   Change Sedona python code to support pyspark 3.3
   
   ## How was this patch tested?
   
   Ran python tests locally against pyspark 3.3
   
   ## Did this PR include necessary documentation updates?
   
   - No, this PR does not affect any public API so no need to change the docs.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-sedona] umartin commented on pull request #635: [SEDONA-128] Change Sedona python code to support pyspark 3.3

Posted by GitBox <gi...@apache.org>.
umartin commented on PR #635:
URL: https://github.com/apache/incubator-sedona/pull/635#issuecomment-1166945124

   I'm closing this since https://github.com/apache/incubator-sedona/pull/636 was merged


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-sedona] umartin commented on pull request #635: [SEDONA-128] Change Sedona python code to support pyspark 3.3

Posted by GitBox <gi...@apache.org>.
umartin commented on PR #635:
URL: https://github.com/apache/incubator-sedona/pull/635#issuecomment-1160813654

   > @umartin You are sure that
   > 
   > ```python
   > SQLContext.getOrCreate(sparkSession.sparkContext)
   > ```
   > 
   > is compatible with previous spark versions ? Other than that it looks good to me. Thanks for contribution.
   
   Yes, I’m quite sure. All tests pass and I also checked “since xx” on the spark api. But I would prefer if the PR for SEDONA-129 got merged instead of this PR as it is more complete regarding spark 3.3. If SEDONA-129 is rejected we can revisit this PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-sedona] Imbruced commented on pull request #635: [SEDONA-128] Change Sedona python code to support pyspark 3.3

Posted by GitBox <gi...@apache.org>.
Imbruced commented on PR #635:
URL: https://github.com/apache/incubator-sedona/pull/635#issuecomment-1160801602

   @umartin You are sure that 
   
   ```python
   SQLContext.getOrCreate(sparkSession.sparkContext)
   
   ```
   
   is compatible with previous spark versions ? 
   Other than that it looks good to me. Thanks for contribution. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-sedona] umartin closed pull request #635: [SEDONA-128] Change Sedona python code to support pyspark 3.3

Posted by GitBox <gi...@apache.org>.
umartin closed pull request #635: [SEDONA-128] Change Sedona python code to support pyspark 3.3
URL: https://github.com/apache/incubator-sedona/pull/635


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org