You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Andrew Gaul <no...@github.com> on 2017/05/08 18:14:48 UTC

[jclouds/jclouds-labs-google] JCLOUDS-944: Promote Google Cloud Storage to core (#176)

You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds-labs-google/pull/176

-- Commit Summary --

  * JCLOUDS-944: Promote Google Cloud Storage to core

-- File Changes --

    D CONTRIBUTING.md (9)
    M README.md (214)
    D google-cloud-storage/README.md (51)
    D google-cloud-storage/pom.xml (172)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/GoogleCloudStorageApi.java (77)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/GoogleCloudStorageApiMetadata.java (96)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/GoogleCloudStorageFallbacks.java (34)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/GoogleCloudStorageProviderMetadata.java (72)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/binders/MultipartUploadBinder.java (69)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/binders/UploadBinder.java (38)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/blobstore/GoogleCloudStorageBlobRequestSigner.java (153)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/blobstore/GoogleCloudStorageBlobStore.java (468)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/blobstore/config/GoogleCloudStorageBlobStoreContextModule.java (44)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/blobstore/functions/BlobMetadataToObjectTemplate.java (56)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/blobstore/functions/BlobStoreListContainerOptionsToListObjectOptions.java (58)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/blobstore/functions/BucketToStorageMetadata.java (45)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/blobstore/functions/ObjectListToStorageMetadata.java (58)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/blobstore/functions/ObjectToBlobMetadata.java (59)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/config/GoogleCloudStorageHttpApiModule.java (63)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/config/GoogleCloudStorageOAuthScopes.java (56)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/config/GoogleCloudStorageParserModule.java (90)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/Bucket.java (181)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/BucketAccessControls.java (122)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/DomainResourceReferences.java (105)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/GoogleCloudStorageObject.java (79)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/ListPageWithPrefixes.java (58)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/ObjectAccessControls.java (133)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/Owner.java (34)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/ProjectTeam.java (55)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/ResumableUpload.java (43)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/RewriteResponse.java (41)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/templates/BucketAccessControlsTemplate.java (33)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/templates/BucketTemplate.java (172)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/templates/ComposeObjectTemplate.java (123)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/templates/ObjectAccessControlsTemplate.java (33)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/templates/ObjectTemplate.java (178)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/features/BucketAccessControlsApi.java (172)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/features/BucketApi.java (281)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/features/DefaultObjectAccessControlsApi.java (180)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/features/ObjectAccessControlsApi.java (317)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/features/ObjectApi.java (532)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/features/ResumableUploadApi.java (185)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/handlers/GoogleCloudStorageErrorHandler.java (75)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/handlers/GoogleCloudStorageRedirectRetryHandler.java (48)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/options/ComposeObjectOptions.java (63)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/options/CopyObjectOptions.java (153)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/options/DeleteBucketOptions.java (51)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/options/DeleteObjectOptions.java (88)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/options/GetBucketOptions.java (61)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/options/GetObjectOptions.java (88)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/options/InsertBucketOptions.java (53)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/options/InsertObjectOptions.java (115)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/options/ListObjectOptions.java (82)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/options/ListOptions.java (53)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/options/RewriteObjectOptions.java (155)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/options/UpdateBucketOptions.java (71)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/options/UpdateObjectOptions.java (100)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/parser/ParseToPayloadEnclosing.java (33)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/parser/ParseToResumableUpload.java (72)
    D google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/reference/GoogleCloudStorageConstants.java (37)
    D google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/GoogleCloudStorageProviderMetadataTest.java (34)
    D google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/blobstore/integration/GoogleCloudStorageBlobIntegrationLiveTest.java (324)
    D google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/blobstore/integration/GoogleCloudStorageBlobLiveTest.java (115)
    D google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/blobstore/integration/GoogleCloudStorageBlobSignerLiveTest.java (36)
    D google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/blobstore/integration/GoogleCloudStorageContainerIntegrationLiveTest.java (106)
    D google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/blobstore/integration/GoogleCloudStorageContainerLiveTest.java (36)
    D google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/features/BucketAccessControlsApiExpectTest.java (188)
    D google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/features/BucketAccessControlsApiLiveTest.java (107)
    D google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/features/BucketApiExpectTest.java (258)
    D google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/features/BucketApiLiveTest.java (301)
    D google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/features/DefaultObjectAccessControlsApiExpectTest.java (219)
    D google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/features/DefaultObjectAccessControlsApiLiveTest.java (110)
    D google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/features/ObjectAccessControlsApiExpectTest.java (276)
    D google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/features/ObjectApiLiveTest.java (478)
    D google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/features/ObjectApiMockTest.java (303)
    D google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/features/ResumableUploadApiLiveTest.java (177)
    D google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/handlers/GoogleCloudStorageErrorHandlerTest.java (107)
    D google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/internal/BaseGoogleCloudStorageApiExpectTest.java (30)
    D google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/internal/BaseGoogleCloudStorageApiLiveTest.java (54)
    D google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/internal/BaseGoogleCloudStorageApiMockTest.java (138)
    D google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/internal/BaseGoogleCloudStorageExpectTest.java (178)
    D google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/internal/BaseGoogleCloudStorageParseTest.java (38)
    D google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/parse/BucketAclGetTest.java (39)
    D google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/parse/BucketAclInsertTest.java (42)
    D google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/parse/BucketAclListTest.java (55)
    D google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/parse/BucketAclUpdateTest.java (39)
    D google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/parse/BucketUpdateTest.java (57)
    D google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/parse/DefaultObjectAclGetTest.java (42)
    D google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/parse/DefaultObjectAclInsertTest.java (38)
    D google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/parse/DefaultObjectAclListTest.java (50)
    D google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/parse/FullBucketGetTest.java (80)
    D google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/parse/NoAclBucketListTest.java (61)
    D google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/parse/NoAclBucketTest.java (57)
    D google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/parse/ObjectAclGetTest.java (49)
    D google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/parse/ObjectAclInsertTest.java (44)
    D google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/parse/ObjectAclListTest.java (51)
    D google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/parse/ObjectAclUpdateTest.java (40)
    D google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/parse/ParseGoogleCloudStorageObject.java (66)
    D google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/parse/ParseGoogleCloudStorageObjectListTest.java (99)
    D google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/parse/ParseObjectRewriteResponse.java (72)
    D google-cloud-storage/src/test/resources/bucket_acl_get.json (9)
    D google-cloud-storage/src/test/resources/bucket_acl_insert_initial.json (4)
    D google-cloud-storage/src/test/resources/bucket_acl_insert_response.json (9)
    D google-cloud-storage/src/test/resources/bucket_acl_list.json (27)
    D google-cloud-storage/src/test/resources/bucket_acl_update_initial.json (4)
    D google-cloud-storage/src/test/resources/bucket_acl_update_response.json (9)
    D google-cloud-storage/src/test/resources/bucket_insert_request_payload.json (3)
    D google-cloud-storage/src/test/resources/bucket_update_request_payload.json (12)
    D google-cloud-storage/src/test/resources/bucket_update_response.json (15)
    D google-cloud-storage/src/test/resources/default_object_acl_get.json (10)
    D google-cloud-storage/src/test/resources/default_object_acl_insert_request_payload.json (4)
    D google-cloud-storage/src/test/resources/default_object_acl_insert_response.json (6)
    D google-cloud-storage/src/test/resources/default_object_acl_list.json (15)
    D google-cloud-storage/src/test/resources/default_object_acl_update_initial.json (6)
    D google-cloud-storage/src/test/resources/default_object_acl_update_request_payload.json (5)
    D google-cloud-storage/src/test/resources/full_bucket_get.json (54)
    D google-cloud-storage/src/test/resources/list_bucket_with_options.json (21)
    D google-cloud-storage/src/test/resources/logback.xml (83)
    D google-cloud-storage/src/test/resources/no_acl_bucket.json (15)
    D google-cloud-storage/src/test/resources/no_acl_bucket_list.json (21)
    D google-cloud-storage/src/test/resources/object_acl_get.json (15)
    D google-cloud-storage/src/test/resources/object_acl_insert_request_payload.json (4)
    D google-cloud-storage/src/test/resources/object_acl_insert_response.json (10)
    D google-cloud-storage/src/test/resources/object_acl_list.json (17)
    D google-cloud-storage/src/test/resources/object_acl_request_payload.json (4)
    D google-cloud-storage/src/test/resources/object_acl_update_initial.json (9)
    D google-cloud-storage/src/test/resources/object_acl_update_response.json (9)
    D google-cloud-storage/src/test/resources/object_compose_request.json (23)
    D google-cloud-storage/src/test/resources/object_encoded_get.json (21)
    D google-cloud-storage/src/test/resources/object_get.json (21)
    D google-cloud-storage/src/test/resources/object_list.json (47)
    D google-cloud-storage/src/test/resources/object_rewrite.json (28)
    D pom.xml (81)

-- Patch Links --

https://github.com/jclouds/jclouds-labs-google/pull/176.patch
https://github.com/jclouds/jclouds-labs-google/pull/176.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/176

Re: [jclouds/jclouds-labs-google] JCLOUDS-944: Promote Google Cloud Storage to core (#176)

Posted by Ignasi Barrera <no...@github.com>.
Let's promote it only in master then.

Should we then create a copy of the release scripts for 2.0.x, so we can cleanly release with or without the jclouds-labs-google repo? Just to make we don't get into issues in the middle of a release process (which is kind of a PITA :D).

-- 
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/176#issuecomment-299988750

Re: [jclouds/jclouds-labs-google] JCLOUDS-944: Promote Google Cloud Storage to core (#176)

Posted by Ignasi Barrera <no...@github.com>.
BTW, in order to release 2.1.0 we must first fix [JCLOUDS-1275 ](https://issues.apache.org/jira/browse/JCLOUDS-1275).

-- 
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/176#issuecomment-300067726

Re: [jclouds/jclouds-labs-google] JCLOUDS-944: Promote Google Cloud Storage to core (#176)

Posted by Andrew Gaul <no...@github.com>.
@nacx Please review modified `README.md`.  Do we need to do anything else to retire this repository, e.g., modify build scripts?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/176#issuecomment-299947096

Re: [jclouds/jclouds-labs-google] JCLOUDS-944: Promote Google Cloud Storage to core (#176)

Posted by Ignasi Barrera <no...@github.com>.
nacx approved this pull request.





-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/176#pullrequestreview-36880206

Re: [jclouds/jclouds-labs-google] JCLOUDS-944: Promote Google Cloud Storage to core (#176)

Posted by Ignasi Barrera <no...@github.com>.
Yes, we need to remove the jclouds-labs-google repo from the script here:
https://dist.apache.org/repos/dist/dev/jclouds/ 

And we need to disable the jclouds-labs-google build for the master and 2.0.x branch in Jenkins.

This said, IMO it would make sense to promote the providers in 2.0.x too. I mean, we say we don't need to keep backwards compatibility in labs providers, but in this case, upgrading would be just a change of the groupId; not a big deal. And we could release a new 2.0.2 after promoting? There are many Azure ARM improvements, so a release would make sense. Thoughts about this, @andrewgaul  @demobox @andreaturli ?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/176#issuecomment-299985919

Re: [jclouds/jclouds-labs-google] JCLOUDS-944: Promote Google Cloud Storage to core (#176)

Posted by Andrew Gaul <no...@github.com>.
I dislike promoting a provider in a bugfix release but if others prefer this I will do the work.  It would be great to release a new version although I prefer 2.1.0.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/176#issuecomment-299987991