You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/11 07:50:19 UTC
[GitHub] [doris] yiguolei opened a new pull request, #15814: [refactor](remove non vectorized) remove non vectorized expr and expr context
yiguolei opened a new pull request, #15814:
URL: https://github.com/apache/doris/pull/15814
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #15814: [refactor](remove non vectorized) remove non vectorized expr and expr context
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on code in PR #15814:
URL: https://github.com/apache/doris/pull/15814#discussion_r1071936931
##########
be/src/exprs/runtime_filter.h:
##########
@@ -147,7 +147,6 @@ class IRuntimeFilter {
_role(RuntimeFilterRole::PRODUCER),
_expr_order(-1),
_always_true(false),
- _probe_ctx(nullptr),
_is_ignored(false),
Review Comment:
warning: initializer '_probe_ctx' does not name a non-static data member or base class; did you mean the member '_vprobe_ctx'? [clang-diagnostic-error]
```suggestion
_vprobe_ctx(nullptr),
```
**be/src/exprs/runtime_filter.h:345:** '_vprobe_ctx' declared here
```cpp
doris::vectorized::VExprContext* _vprobe_ctx;
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #15814: [refactor](remove non vectorized) remove non vectorized expr and expr context
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on code in PR #15814:
URL: https://github.com/apache/doris/pull/15814#discussion_r1072021797
##########
be/src/exprs/expr.cpp:
##########
@@ -30,18 +30,15 @@
#include "exprs/aggregate_functions.h"
#include "exprs/anyval_util.h"
#include "exprs/arithmetic_expr.h"
-#include "exprs/binary_predicate.h"
#include "exprs/case_expr.h"
Review Comment:
warning: 'exprs/case_expr.h' file not found [clang-diagnostic-error]
```cpp
#include "exprs/case_expr.h"
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15814: [refactor](remove non vectorized) remove non vectorized expr and expr context
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15814:
URL: https://github.com/apache/doris/pull/15814#issuecomment-1385256496
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15814: [refactor](remove non vectorized) remove non vectorized expr and expr context
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15814:
URL: https://github.com/apache/doris/pull/15814#issuecomment-1385280331
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei closed pull request #15814: [refactor](remove non vectorized) remove non vectorized expr and expr context
Posted by GitBox <gi...@apache.org>.
yiguolei closed pull request #15814: [refactor](remove non vectorized) remove non vectorized expr and expr context
URL: https://github.com/apache/doris/pull/15814
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15814: [refactor](remove non vectorized) remove non vectorized expr and expr context
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15814:
URL: https://github.com/apache/doris/pull/15814#issuecomment-1385216357
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15814: [refactor](remove non vectorized) remove non vectorized expr and expr context
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15814:
URL: https://github.com/apache/doris/pull/15814#issuecomment-1385023006
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15814: [refactor](remove non vectorized) remove non vectorized expr and expr context
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15814:
URL: https://github.com/apache/doris/pull/15814#issuecomment-1385058777
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org