You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flink.apache.org by Feng Jin <ji...@gmail.com> on 2024/01/05 02:48:31 UTC
[VOTE] FLIP-387: Support named parameters for functions and call procedures
Hi everyone
Thanks for all the feedback about the FLIP-387: Support named parameters
for functions and call procedures [1] [2] .
I'd like to start a vote for it. The vote will be open for at least 72
hours(excluding weekends,until Jan 10, 12:00AM GMT) unless there is an
objection or an insufficient number of votes.
[1]
https://cwiki.apache.org/confluence/display/FLINK/FLIP-387%3A+Support+named+parameters+for+functions+and+call+procedures
[2] https://lists.apache.org/thread/bto7mpjvcx7d7k86owb00dwrm65jx8cn
Best,
Feng Jin
Re: [VOTE] FLIP-387: Support named parameters for functions and call procedures
Posted by Timo Walther <tw...@apache.org>.
Thanks for the last minute change.
+1 (binding)
Cheers,
Timo
On 05.01.24 08:59, Feng Jin wrote:
> Hi Timo,
>
> Thank you for the suggestion. Previously, I thought most parameters were
> optional, so the default value was set to true.
>
> Your concern is reasonable. We should declare it as false by default and
> developers should explicitly state if a parameter is optional instead of
> using our default value.
>
> Regarding this part, I have already made modifications in the document.
>
>
> Best,
> Feng
>
>
> On Fri, Jan 5, 2024 at 3:38 PM Timo Walther <tw...@apache.org> wrote:
>
>> Thanks, for starting the VOTE thread and thanks for considering my
>> feedback. One last comment before I'm also happy to give my +1 to this:
>>
>> Why is ArgumentHint's default isOptinal=true? Shouldn't it be false by
>> default? Many function implementers will forget to set this to false and
>> suddenly get NULLs passed to their functions. Marking an argument as
>> optional should be an explicit decision of an implementer.
>>
>> Regards,
>> Timo
>>
>>
>> On 05.01.24 05:06, Lincoln Lee wrote:
>>> +1 (binding)
>>>
>>> Best,
>>> Lincoln Lee
>>>
>>>
>>> Benchao Li <li...@apache.org> 于2024年1月5日周五 11:46写道：
>>>
>>>> +1 (binding)
>>>>
>>>> Feng Jin <ji...@gmail.com> 于2024年1月5日周五 10:49写道：
>>>>>
>>>>> Hi everyone
>>>>>
>>>>> Thanks for all the feedback about the FLIP-387: Support named
>> parameters
>>>>> for functions and call procedures [1] [2] .
>>>>>
>>>>> I'd like to start a vote for it. The vote will be open for at least 72
>>>>> hours(excluding weekends,until Jan 10, 12:00AM GMT) unless there is an
>>>>> objection or an insufficient number of votes.
>>>>>
>>>>>
>>>>>
>>>>> [1]
>>>>>
>>>>
>> https://cwiki.apache.org/confluence/display/FLINK/FLIP-387%3A+Support+named+parameters+for+functions+and+call+procedures
>>>>> [2] https://lists.apache.org/thread/bto7mpjvcx7d7k86owb00dwrm65jx8cn
>>>>>
>>>>>
>>>>> Best,
>>>>> Feng Jin
>>>>
>>>>
>>>>
>>>> --
>>>>
>>>> Best,
>>>> Benchao Li
>>>>
>>>
>>
>>
>
Re: [VOTE] FLIP-387: Support named parameters for functions and call procedures
Posted by Feng Jin <ji...@gmail.com>.
Hi Timo,
Thank you for the suggestion. Previously, I thought most parameters were
optional, so the default value was set to true.
Your concern is reasonable. We should declare it as false by default and
developers should explicitly state if a parameter is optional instead of
using our default value.
Regarding this part, I have already made modifications in the document.
Best,
Feng
On Fri, Jan 5, 2024 at 3:38 PM Timo Walther <tw...@apache.org> wrote:
> Thanks, for starting the VOTE thread and thanks for considering my
> feedback. One last comment before I'm also happy to give my +1 to this:
>
> Why is ArgumentHint's default isOptinal=true? Shouldn't it be false by
> default? Many function implementers will forget to set this to false and
> suddenly get NULLs passed to their functions. Marking an argument as
> optional should be an explicit decision of an implementer.
>
> Regards,
> Timo
>
>
> On 05.01.24 05:06, Lincoln Lee wrote:
> > +1 (binding)
> >
> > Best,
> > Lincoln Lee
> >
> >
> > Benchao Li <li...@apache.org> 于2024年1月5日周五 11:46写道：
> >
> >> +1 (binding)
> >>
> >> Feng Jin <ji...@gmail.com> 于2024年1月5日周五 10:49写道：
> >>>
> >>> Hi everyone
> >>>
> >>> Thanks for all the feedback about the FLIP-387: Support named
> parameters
> >>> for functions and call procedures [1] [2] .
> >>>
> >>> I'd like to start a vote for it. The vote will be open for at least 72
> >>> hours(excluding weekends,until Jan 10, 12:00AM GMT) unless there is an
> >>> objection or an insufficient number of votes.
> >>>
> >>>
> >>>
> >>> [1]
> >>>
> >>
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-387%3A+Support+named+parameters+for+functions+and+call+procedures
> >>> [2] https://lists.apache.org/thread/bto7mpjvcx7d7k86owb00dwrm65jx8cn
> >>>
> >>>
> >>> Best,
> >>> Feng Jin
> >>
> >>
> >>
> >> --
> >>
> >> Best,
> >> Benchao Li
> >>
> >
>
>
Re: [VOTE] FLIP-387: Support named parameters for functions and call procedures
Posted by Timo Walther <tw...@apache.org>.
Thanks, for starting the VOTE thread and thanks for considering my
feedback. One last comment before I'm also happy to give my +1 to this:
Why is ArgumentHint's default isOptinal=true? Shouldn't it be false by
default? Many function implementers will forget to set this to false and
suddenly get NULLs passed to their functions. Marking an argument as
optional should be an explicit decision of an implementer.
Regards,
Timo
On 05.01.24 05:06, Lincoln Lee wrote:
> +1 (binding)
>
> Best,
> Lincoln Lee
>
>
> Benchao Li <li...@apache.org> 于2024年1月5日周五 11:46写道：
>
>> +1 (binding)
>>
>> Feng Jin <ji...@gmail.com> 于2024年1月5日周五 10:49写道：
>>>
>>> Hi everyone
>>>
>>> Thanks for all the feedback about the FLIP-387: Support named parameters
>>> for functions and call procedures [1] [2] .
>>>
>>> I'd like to start a vote for it. The vote will be open for at least 72
>>> hours(excluding weekends,until Jan 10, 12:00AM GMT) unless there is an
>>> objection or an insufficient number of votes.
>>>
>>>
>>>
>>> [1]
>>>
>> https://cwiki.apache.org/confluence/display/FLINK/FLIP-387%3A+Support+named+parameters+for+functions+and+call+procedures
>>> [2] https://lists.apache.org/thread/bto7mpjvcx7d7k86owb00dwrm65jx8cn
>>>
>>>
>>> Best,
>>> Feng Jin
>>
>>
>>
>> --
>>
>> Best,
>> Benchao Li
>>
>
Re: [VOTE] FLIP-387: Support named parameters for functions and call procedures
Posted by Lincoln Lee <li...@gmail.com>.
+1 (binding)
Best,
Lincoln Lee
Benchao Li <li...@apache.org> 于2024年1月5日周五 11:46写道：
> +1 (binding)
>
> Feng Jin <ji...@gmail.com> 于2024年1月5日周五 10:49写道：
> >
> > Hi everyone
> >
> > Thanks for all the feedback about the FLIP-387: Support named parameters
> > for functions and call procedures [1] [2] .
> >
> > I'd like to start a vote for it. The vote will be open for at least 72
> > hours(excluding weekends,until Jan 10, 12:00AM GMT) unless there is an
> > objection or an insufficient number of votes.
> >
> >
> >
> > [1]
> >
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-387%3A+Support+named+parameters+for+functions+and+call+procedures
> > [2] https://lists.apache.org/thread/bto7mpjvcx7d7k86owb00dwrm65jx8cn
> >
> >
> > Best,
> > Feng Jin
>
>
>
> --
>
> Best,
> Benchao Li
>
Re: [VOTE] FLIP-387: Support named parameters for functions and call procedures
Posted by Benchao Li <li...@apache.org>.
+1 (binding)
Feng Jin <ji...@gmail.com> 于2024年1月5日周五 10:49写道：
>
> Hi everyone
>
> Thanks for all the feedback about the FLIP-387: Support named parameters
> for functions and call procedures [1] [2] .
>
> I'd like to start a vote for it. The vote will be open for at least 72
> hours(excluding weekends,until Jan 10, 12:00AM GMT) unless there is an
> objection or an insufficient number of votes.
>
>
>
> [1]
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-387%3A+Support+named+parameters+for+functions+and+call+procedures
> [2] https://lists.apache.org/thread/bto7mpjvcx7d7k86owb00dwrm65jx8cn
>
>
> Best,
> Feng Jin
--
Best,
Benchao Li
Re: Re: [VOTE] FLIP-387: Support named parameters for functions and call procedures
Posted by Feng Jin <ji...@gmail.com>.
Thank you all! Closing the vote. The result will be sent in a separate
email.
Best,
Feng Jin
On Wed, Jan 10, 2024 at 2:04 PM Hang Ruan <ru...@gmail.com> wrote:
> +1 (non-binding)
>
> Best,
> Hang
>
> Jingsong Li <ji...@gmail.com> 于2024年1月10日周三 12:03写道：
>
> > +1
> >
> > On Wed, Jan 10, 2024 at 11:24 AM Xuyang <xy...@163.com> wrote:
> > >
> > > +1(non-binding)--
> > >
> > > Best！
> > > Xuyang
> > >
> > >
> > >
> > >
> > >
> > > 在 2024-01-08 00:34:55，"Feng Jin" <ji...@gmail.com> 写道：
> > > >Hi Alexey
> > > >
> > > >Thank you for the reminder, the link has been updated.
> > > >
> > > >Best,
> > > >Feng Jin
> > > >
> > > >On Sat, Jan 6, 2024 at 12:55 AM Alexey Leonov-Vendrovskiy <
> > > >vendrovsky@gmail.com> wrote:
> > > >
> > > >> Thanks for starting the vote!
> > > >> Do you mind adding a link from the FLIP to this thread?
> > > >>
> > > >> Thanks,
> > > >> Alexey
> > > >>
> > > >> On Thu, Jan 4, 2024 at 6:48 PM Feng Jin <ji...@gmail.com>
> > wrote:
> > > >>
> > > >> > Hi everyone
> > > >> >
> > > >> > Thanks for all the feedback about the FLIP-387: Support named
> > parameters
> > > >> > for functions and call procedures [1] [2] .
> > > >> >
> > > >> > I'd like to start a vote for it. The vote will be open for at
> least
> > 72
> > > >> > hours(excluding weekends,until Jan 10, 12:00AM GMT) unless there
> is
> > an
> > > >> > objection or an insufficient number of votes.
> > > >> >
> > > >> >
> > > >> >
> > > >> > [1]
> > > >> >
> > > >> >
> > > >>
> >
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-387%3A+Support+named+parameters+for+functions+and+call+procedures
> > > >> > [2]
> > https://lists.apache.org/thread/bto7mpjvcx7d7k86owb00dwrm65jx8cn
> > > >> >
> > > >> >
> > > >> > Best,
> > > >> > Feng Jin
> > > >> >
> > > >>
> >
>
Re: Re: [VOTE] FLIP-387: Support named parameters for functions and call procedures
Posted by Hang Ruan <ru...@gmail.com>.
+1 (non-binding)
Best,
Hang
Jingsong Li <ji...@gmail.com> 于2024年1月10日周三 12:03写道：
> +1
>
> On Wed, Jan 10, 2024 at 11:24 AM Xuyang <xy...@163.com> wrote:
> >
> > +1(non-binding)--
> >
> > Best！
> > Xuyang
> >
> >
> >
> >
> >
> > 在 2024-01-08 00:34:55，"Feng Jin" <ji...@gmail.com> 写道：
> > >Hi Alexey
> > >
> > >Thank you for the reminder, the link has been updated.
> > >
> > >Best,
> > >Feng Jin
> > >
> > >On Sat, Jan 6, 2024 at 12:55 AM Alexey Leonov-Vendrovskiy <
> > >vendrovsky@gmail.com> wrote:
> > >
> > >> Thanks for starting the vote!
> > >> Do you mind adding a link from the FLIP to this thread?
> > >>
> > >> Thanks,
> > >> Alexey
> > >>
> > >> On Thu, Jan 4, 2024 at 6:48 PM Feng Jin <ji...@gmail.com>
> wrote:
> > >>
> > >> > Hi everyone
> > >> >
> > >> > Thanks for all the feedback about the FLIP-387: Support named
> parameters
> > >> > for functions and call procedures [1] [2] .
> > >> >
> > >> > I'd like to start a vote for it. The vote will be open for at least
> 72
> > >> > hours(excluding weekends,until Jan 10, 12:00AM GMT) unless there is
> an
> > >> > objection or an insufficient number of votes.
> > >> >
> > >> >
> > >> >
> > >> > [1]
> > >> >
> > >> >
> > >>
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-387%3A+Support+named+parameters+for+functions+and+call+procedures
> > >> > [2]
> https://lists.apache.org/thread/bto7mpjvcx7d7k86owb00dwrm65jx8cn
> > >> >
> > >> >
> > >> > Best,
> > >> > Feng Jin
> > >> >
> > >>
>
Re: Re: [VOTE] FLIP-387: Support named parameters for functions and call procedures
Posted by Jingsong Li <ji...@gmail.com>.
+1
On Wed, Jan 10, 2024 at 11:24 AM Xuyang <xy...@163.com> wrote:
>
> +1(non-binding)--
>
> Best！
> Xuyang
>
>
>
>
>
> 在 2024-01-08 00:34:55，"Feng Jin" <ji...@gmail.com> 写道：
> >Hi Alexey
> >
> >Thank you for the reminder, the link has been updated.
> >
> >Best,
> >Feng Jin
> >
> >On Sat, Jan 6, 2024 at 12:55 AM Alexey Leonov-Vendrovskiy <
> >vendrovsky@gmail.com> wrote:
> >
> >> Thanks for starting the vote!
> >> Do you mind adding a link from the FLIP to this thread?
> >>
> >> Thanks,
> >> Alexey
> >>
> >> On Thu, Jan 4, 2024 at 6:48 PM Feng Jin <ji...@gmail.com> wrote:
> >>
> >> > Hi everyone
> >> >
> >> > Thanks for all the feedback about the FLIP-387: Support named parameters
> >> > for functions and call procedures [1] [2] .
> >> >
> >> > I'd like to start a vote for it. The vote will be open for at least 72
> >> > hours(excluding weekends,until Jan 10, 12:00AM GMT) unless there is an
> >> > objection or an insufficient number of votes.
> >> >
> >> >
> >> >
> >> > [1]
> >> >
> >> >
> >> https://cwiki.apache.org/confluence/display/FLINK/FLIP-387%3A+Support+named+parameters+for+functions+and+call+procedures
> >> > [2] https://lists.apache.org/thread/bto7mpjvcx7d7k86owb00dwrm65jx8cn
> >> >
> >> >
> >> > Best,
> >> > Feng Jin
> >> >
> >>
Re:Re: [VOTE] FLIP-387: Support named parameters for functions and call procedures
Posted by Xuyang <xy...@163.com>.
+1(non-binding)--
Best！
Xuyang
在 2024-01-08 00:34:55，"Feng Jin" <ji...@gmail.com> 写道：
>Hi Alexey
>
>Thank you for the reminder, the link has been updated.
>
>Best,
>Feng Jin
>
>On Sat, Jan 6, 2024 at 12:55 AM Alexey Leonov-Vendrovskiy <
>vendrovsky@gmail.com> wrote:
>
>> Thanks for starting the vote!
>> Do you mind adding a link from the FLIP to this thread?
>>
>> Thanks,
>> Alexey
>>
>> On Thu, Jan 4, 2024 at 6:48 PM Feng Jin <ji...@gmail.com> wrote:
>>
>> > Hi everyone
>> >
>> > Thanks for all the feedback about the FLIP-387: Support named parameters
>> > for functions and call procedures [1] [2] .
>> >
>> > I'd like to start a vote for it. The vote will be open for at least 72
>> > hours(excluding weekends,until Jan 10, 12:00AM GMT) unless there is an
>> > objection or an insufficient number of votes.
>> >
>> >
>> >
>> > [1]
>> >
>> >
>> https://cwiki.apache.org/confluence/display/FLINK/FLIP-387%3A+Support+named+parameters+for+functions+and+call+procedures
>> > [2] https://lists.apache.org/thread/bto7mpjvcx7d7k86owb00dwrm65jx8cn
>> >
>> >
>> > Best,
>> > Feng Jin
>> >
>>
Re: [VOTE] FLIP-387: Support named parameters for functions and call procedures
Posted by Feng Jin <ji...@gmail.com>.
Hi Alexey
Thank you for the reminder, the link has been updated.
Best,
Feng Jin
On Sat, Jan 6, 2024 at 12:55 AM Alexey Leonov-Vendrovskiy <
vendrovsky@gmail.com> wrote:
> Thanks for starting the vote!
> Do you mind adding a link from the FLIP to this thread?
>
> Thanks,
> Alexey
>
> On Thu, Jan 4, 2024 at 6:48 PM Feng Jin <ji...@gmail.com> wrote:
>
> > Hi everyone
> >
> > Thanks for all the feedback about the FLIP-387: Support named parameters
> > for functions and call procedures [1] [2] .
> >
> > I'd like to start a vote for it. The vote will be open for at least 72
> > hours(excluding weekends,until Jan 10, 12:00AM GMT) unless there is an
> > objection or an insufficient number of votes.
> >
> >
> >
> > [1]
> >
> >
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-387%3A+Support+named+parameters+for+functions+and+call+procedures
> > [2] https://lists.apache.org/thread/bto7mpjvcx7d7k86owb00dwrm65jx8cn
> >
> >
> > Best,
> > Feng Jin
> >
>
Re: [VOTE] FLIP-387: Support named parameters for functions and call procedures
Posted by Alexey Leonov-Vendrovskiy <ve...@gmail.com>.
Thanks for starting the vote!
Do you mind adding a link from the FLIP to this thread?
Thanks,
Alexey
On Thu, Jan 4, 2024 at 6:48 PM Feng Jin <ji...@gmail.com> wrote:
> Hi everyone
>
> Thanks for all the feedback about the FLIP-387: Support named parameters
> for functions and call procedures [1] [2] .
>
> I'd like to start a vote for it. The vote will be open for at least 72
> hours(excluding weekends,until Jan 10, 12:00AM GMT) unless there is an
> objection or an insufficient number of votes.
>
>
>
> [1]
>
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-387%3A+Support+named+parameters+for+functions+and+call+procedures
> [2] https://lists.apache.org/thread/bto7mpjvcx7d7k86owb00dwrm65jx8cn
>
>
> Best,
> Feng Jin
>